# Re: \[PATCH v2 1/5\] export\_report: Rehabilitate script

- From: Greg KH \<gregkh@linuxfoundation.org\>
- Date: 2023-11-18 11:35:21 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/11/2402584
- Thread: https://ratatoskr.run/linuxppc-dev/2023/11/2402454/t.md

```text
On Sat, Nov 18, 2023 at 02:54:42AM +0000, Matthew Maurer wrote:
> * modules.order has .o files when in a build dir, support this
> * .mod.c source layout has changed, update regexes to match
> * Add a stage 3, to be more robust against additional .mod.c content

When you have to list different things you do in a patch, that is a huge
hint that you need to break up your patch into smaller pieces.

Remember, each patch can only do one logical thing.  I know it feels
odd, but it makes it easier to review.

This patch, as-is, is nothing that I would be able to take, please make
it a series.

thanks,

greg k-h
```