[PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask
Subsystems:
pci driver for freescale layerscape, pci native host bridge and endpoint drivers, pci subsystem, the rest
STALE1039d
LANDED
Landed in mainline as 81ef01bc5934 on 2023-10-10.
7 messages,
5 authors,
2023-10-10 · open the first message on its own page
From: Guanhua Gao <redacted>
Set DMA mask and coherent DMA mask to enable 64-bit addressing.
Signed-off-by: Guanhua Gao <redacted>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Notes:
change from v2 to v3
- remove check return value of dma_set_mask_and_coherent. 64bit mask always
return success.
- remove redundate comments
change from v1 to v2
- Remove 32bit DMA mask set.
drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index de4c1758a6c3..2c2c9aaa8700 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
+ dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
+
platform_set_drvdata(pdev, pcie);
ret = dw_pcie_ep_init(&pci->ep);
--
2.34.1
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote:
From: Guanhua Gao <redacted>
Set DMA mask and coherent DMA mask to enable 64-bit addressing.
Signed-off-by: Guanhua Gao <redacted>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Acked-by: Manivannan Sadhasivam <redacted>
- Mani
quoted hunk
---
Notes:
change from v2 to v3
- remove check return value of dma_set_mask_and_coherent. 64bit mask always
return success.
- remove redundate comments
change from v1 to v2
- Remove 32bit DMA mask set.
drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index de4c1758a6c3..2c2c9aaa8700 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
+ dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
+
platform_set_drvdata(pdev, pcie);
ret = dw_pcie_ep_init(&pci->ep);
--
2.34.1
--
மணிவண்ணன் சதாசிவம்
quoted hunk
-----Original Message-----
From: Frank Li <frank.li@nxp.com>
Sent: Tuesday, September 26, 2023 9:05 AM
From: Guanhua Gao <redacted>
Set DMA mask and coherent DMA mask to enable 64-bit addressing.
Signed-off-by: Guanhua Gao <redacted>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Notes:
change from v2 to v3
- remove check return value of dma_set_mask_and_coherent. 64bit mask
always
return success.
- remove redundate comments
change from v1 to v2
- Remove 32bit DMA mask set.
drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index de4c1758a6c3..2c2c9aaa8700 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct
platform_device *pdev)
pcie->big_endian = of_property_read_bool(dev->of_node, "big-
endian");
+ dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
+
Acked-by: Roy Zang <Roy.Zang@nxp.com>
-R
On Wed, Sep 27, 2023 at 02:46:21PM +0200, Manivannan Sadhasivam wrote:
On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote:
quoted
From: Guanhua Gao <redacted>
Set DMA mask and coherent DMA mask to enable 64-bit addressing.
Signed-off-by: Guanhua Gao <redacted>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Acked-by: Manivannan Sadhasivam <redacted>
@Lorenzo
Could you please consider pick this patch?
Manivannan already reviewed and only impact layerscape.
Frank
- Mani
quoted
---
Notes:
change from v2 to v3
- remove check return value of dma_set_mask_and_coherent. 64bit mask always
return success.
- remove redundate comments
change from v1 to v2
- Remove 32bit DMA mask set.
drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index de4c1758a6c3..2c2c9aaa8700 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
+ dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
+
platform_set_drvdata(pdev, pcie);
ret = dw_pcie_ep_init(&pci->ep);
--
2.34.1
--
மணிவண்ணன் சதாசிவம்
On Tue, 26 Sep 2023 10:04:45 -0400, Frank Li wrote:
Set DMA mask and coherent DMA mask to enable 64-bit addressing.
Read this:
https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com
Find the issue with the commit log (that I fixed).
This does not apply to v6.6-rc1 so I tweaked it,
check that everything is OK please.
Applied to controller/layerscape, thanks!
[1/1] PCI: layerscape-ep: set 64-bit DMA mask
https://git.kernel.org/pci/pci/c/81ef01bc5934
Thanks,
Lorenzo
On Tue, Oct 10, 2023 at 05:44:23PM +0200, Lorenzo Pieralisi wrote:
On Tue, 26 Sep 2023 10:04:45 -0400, Frank Li wrote:
quoted
Set DMA mask and coherent DMA mask to enable 64-bit addressing.
Read this:
https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com
Find the issue with the commit log (that I fixed).
Do you means "set" should be "Set"?
Frank
This does not apply to v6.6-rc1 so I tweaked it,
check that everything is OK please.
Applied to controller/layerscape, thanks!
Thanks, everthing is good!
[1/1] PCI: layerscape-ep: set 64-bit DMA mask
https://git.kernel.org/pci/pci/c/81ef01bc5934
Thanks,
Lorenzo