# \[PATCH\] ocxl: Use pci\_dev\_id() to simplify the code

- Subsystems: LINUX FOR POWERPC (32-BIT AND 64-BIT), OCXL (Open Coherent Accelerator Processor Interface OpenCAPI) DRIVER, THE REST
- Maintainers: Madhavan Srinivasan, Mahesh J Salgaonkar, Linus Torvalds
- Status: LANDED (075a88d5eb28 · 2023-08-16 13:54)
- Landed in mainline as 075a88d5eb28 on 2023-08-16.
- List: linuxppc-dev
- 4 messages, 4 authors
- Page: https://ratatoskr.run/linuxppc-dev/2023/08/9531721/t

## \[PATCH\] ocxl: Use pci\_dev\_id() to simplify the code

- From: Zheng Zengkai \<hidden\>
- Date: 2023-08-11 21:01:52 
- Message: https://ratatoskr.run/linuxppc-dev/2023/08/9531721.md

```text
PCI core API pci_dev_id() can be used to get the BDF number for a pci
device. We don't need to compose it mannually. Use pci_dev_id() to
simplify the code a little bit.

Signed-off-by: Zheng Zengkai <redacted>
---
 arch/powerpc/platforms/powernv/ocxl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/ocxl.c b/arch/powerpc/platforms/powernv/ocxl.c
index 629067781cec..64a9c7125c29 100644
--- a/arch/powerpc/platforms/powernv/ocxl.c
+++ b/arch/powerpc/platforms/powernv/ocxl.c
@@ -449,7 +449,7 @@ int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask,
 	if (!data)
 		return -ENOMEM;
 
-	bdfn = (dev->bus->number << 8) | dev->devfn;
+	bdfn = pci_dev_id(dev);
 	rc = opal_npu_spa_setup(phb->opal_id, bdfn, virt_to_phys(spa_mem),
 				PE_mask);
 	if (rc) {
-- 
2.20.1

```

## Re: \[PATCH\] ocxl: Use pci\_dev\_id() to simplify the code

- From: Frederic Barrat \<hidden\>
- Date: 2023-08-11 13:01:50 
- Message: https://ratatoskr.run/linuxppc-dev/2023/08/9531718.md

```text


On 11/08/2023 12:20, Zheng Zengkai wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a pci
> device. We don't need to compose it mannually. Use pci_dev_id() to
> simplify the code a little bit.
>
> Signed-off-by: Zheng Zengkai <redacted>
> ---

LGTM
Acked-by: Frederic Barrat <redacted>

  Fred


>   arch/powerpc/platforms/powernv/ocxl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/ocxl.c b/arch/powerpc/platforms/powernv/ocxl.c
> index 629067781cec..64a9c7125c29 100644
> --- a/arch/powerpc/platforms/powernv/ocxl.c
> +++ b/arch/powerpc/platforms/powernv/ocxl.c
> @@ -449,7 +449,7 @@ int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask,
>   	if (!data)
>   		return -ENOMEM;
>   
> -	bdfn = (dev->bus->number << 8) | dev->devfn;
> +	bdfn = pci_dev_id(dev);
>   	rc = opal_npu_spa_setup(phb->opal_id, bdfn, virt_to_phys(spa_mem),
>   				PE_mask);
>   	if (rc) {
```

## Re: \[PATCH\] ocxl: Use pci\_dev\_id() to simplify the code

- From: Andrew Donnellan \<hidden\>
- Date: 2023-08-14 07:08:46 
- Message: https://ratatoskr.run/linuxppc-dev/2023/08/9531723.md

```text
On Fri, 2023-08-11 at 18:20 +0800, Zheng Zengkai wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a pci
> device. We don't need to compose it mannually. Use pci_dev_id() to
> simplify the code a little bit.
> 
> Signed-off-by: Zheng Zengkai <redacted>

Acked-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited
```

## Re: \[PATCH\] ocxl: Use pci\_dev\_id() to simplify the code

- From: Michael Ellerman \<hidden\>
- Date: 2023-08-23 12:23:53 
- Message: https://ratatoskr.run/linuxppc-dev/2023/08/9531853.md

```text
On Fri, 11 Aug 2023 18:20:39 +0800, Zheng Zengkai wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a pci
> device. We don't need to compose it mannually. Use pci_dev_id() to
> simplify the code a little bit.
> 
> 

Applied to powerpc/next.

[1/1] ocxl: Use pci_dev_id() to simplify the code
      https://git.kernel.org/powerpc/c/075a88d5eb2806712c64bed98c30b6890ec30311

cheers
```