# Re: \[PATCH v4 21/28\] net: wan: Add framer framework support

- From: Linus Walleij \<hidden\>
- Date: 2023-08-20 21:08:58 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/08/2309283
- Thread: https://ratatoskr.run/netdev/2023/08/2308506/t.md

```text
On Fri, Aug 18, 2023 at 6:41 PM Christophe Leroy
[ref] wrote:

> From: Herve Codina <herve.codina@bootlin.com>
>
> A framer is a component in charge of an E1/T1 line interface.
> Connected usually to a TDM bus, it converts TDM frames to/from E1/T1
> frames. It also provides information related to the E1/T1 line.
>
> The framer framework provides a set of APIs for the framer drivers
> (framer provider) to create/destroy a framer and APIs for the framer
> users (framer consumer) to obtain a reference to the framer, and
> use the framer.
>
> This basic implementation provides a framer abstraction for:
>  - power on/off the framer
>  - get the framer status (line state)
>  - be notified on framer status changes
>  - get/set the framer configuration
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Christophe Leroy <redacted>
> Signed-off-by: Christophe Leroy <redacted>

I had these review comments, you must have missed them?
https://lore.kernel.org/netdev/CACRpkdZQ9_f6+9CseV1L_wGphHujFPAYXMjJfjUrzSZRakOBzg@mail.gmail.com/

Yours,
Linus Walleij
```
