# Re: \[PATCH v2 10/28\] soc: fsl: cpm1: qmc: Introduce qmc\_chan\_setup\_tsa\*

- From: Herve Codina \<herve.codina@bootlin.com\>
- Date: 2023-08-01 10:27:15 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/08/2286982
- Thread: https://ratatoskr.run/netdev/2023/07/2280248/t.md

```text
On Tue, 1 Aug 2023 11:36:43 +0200
Andrew Lunn [ref] wrote:

> > +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set)
> > +{
> > +	qmc_write16(addr, (qmc_read16(addr) & ~clr) | set);
> > +}
> > +  
> 
> Please don't use inline in .c files. Let the compiler decide.
> 
>        Andrew

Ok, I will remove the inline in the next iteration.
I will also remove the inline of all other similar functions (probably a
separate patch in the series).

Regards,
Hervé
```
