# Re: \[PATCH v2 10/28\] soc: fsl: cpm1: qmc: Introduce qmc\_chan\_setup\_tsa\*

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2023-08-01 09:39:55 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/08/2286923
- Thread: https://ratatoskr.run/netdev/2023/07/2280248/t.md

```text
> +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set)
> +{
> +	qmc_write16(addr, (qmc_read16(addr) & ~clr) | set);
> +}
> +

Please don't use inline in .c files. Let the compiler decide.

       Andrew
```
