From: Frank Li <Frank.Li@nxp.com> Date: 2023-07-19 15:57:37
Add support to pass Link down notification to Endpoint function driver
so that the LINK_DOWN event can be processed by the function.
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- none
Change from v1 to v2
- move pci_epc_linkdown() after dev_dbg()
drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
1 file changed, 1 insertion(+)
From: Frank Li <Frank.Li@nxp.com> Date: 2023-07-19 15:57:44
From: Xiaowei Bao <redacted>
A workaround for the issue where the PCI Express Endpoint (EP) controller
loses the values of the Maximum Link Width and Supported Link Speed from
the Link Capabilities Register, which initially configured by the Reset
Configuration Word (RCW) during a link-down or hot reset event.
Fixes: a805770d8a22 ("PCI: layerscape: Add EP mode support")
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Xiaowei Bao <redacted>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change from v2 to v3
- fix subject typo capabilities
change from v1 to v2:
- add comments at restore register
- add fixes tag
- dw_pcie_writew_dbi to dw_pcie_writel_dbi
.../pci/controller/dwc/pci-layerscape-ep.c | 21 ++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
From: Frank Li <Frank.li@nxp.com> Date: 2023-07-19 19:45:16
On Wed, Jul 19, 2023 at 09:27:23PM +0200, Markus Elfring wrote:
quoted
Add support to pass …
Why did you omit a cover letter for the discussed patch series once more?
Your comments is
"Will a cover letter become helpful also for the presented small patch series?"
According to my understand it is optional. I don't think cover letter will
help this case. Patch 1 and 2 is that independent at all.
I sent these together just because easy to test once.
Maintainer can pick any one individually.
Cover letter just annoise people here.
Frank
Do you care for consequences according to message threading?
Regards,
Markus
"You may like to include a cover letter with your patch series."
Generally, I think cover letter will be needed only if it really
help reviewer to get main idea about patches.
Such as my on going pathes(with cover letter):
https://lore.kernel.org/imx/ZLglBiSz0meJm5os@lizhi-Precision-Tower-5810/T/#t
Similar case without(cover leter) and accepted.
https://lore.kernel.org/imx/20230719063425.GE151430@dragon/T/#t
I don't think cover letter real help reviewer to review these two patches.
I more like to get "real problem"(such as comments about "typo").
It is just waste time to discuss if need add cover letter here.
Frank
From: Frank Li <Frank.li@nxp.com> Date: 2023-07-19 22:23:55
On Wed, Jul 19, 2023 at 11:57:07AM -0400, Frank Li wrote:
quoted hunk
From: Xiaowei Bao <redacted>
A workaround for the issue where the PCI Express Endpoint (EP) controller
loses the values of the Maximum Link Width and Supported Link Speed from
the Link Capabilities Register, which initially configured by the Reset
Configuration Word (RCW) during a link-down or hot reset event.
Fixes: a805770d8a22 ("PCI: layerscape: Add EP mode support")
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Xiaowei Bao <redacted>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change from v2 to v3
- fix subject typo capabilities
change from v1 to v2:
- add comments at restore register
- add fixes tag
- dw_pcie_writew_dbi to dw_pcie_writel_dbi
.../pci/controller/dwc/pci-layerscape-ep.c | 21 ++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)