# Re: \[PATCH\] usb: Explicitly include correct DT includes

- From: Rob Herring \<robh@kernel.org\>
- Date: 2023-07-17 17:43:34 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/07/2268096
- Thread: https://ratatoskr.run/linux-devicetree/2023/07/2265963/t.md

```text
On Fri, Jul 14, 2023 at 11:50 AM Rob Herring [ref] wrote:
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

[...]

> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index a9877f2569f4..2574bccc151b 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -10,10 +10,12 @@
>  #include <linux/fsl_devices.h>
>  #include <linux/err.h>
>  #include <linux/io.h>
> -#include <linux/of_platform.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
>  #include <linux/clk.h>
>  #include <linux/module.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/of.h>

Double include of of.h here. v2 coming.

Rob
```
