On 6/10/23 18:21, Vladimir Oltean wrote:

Hello Sean,

On Fri, Jun 09, 2023 at 03:19:22PM -0400, Sean Anderson wrote:

quoted

On 5/22/23 11:00, Vladimir Oltean wrote:

quoted

On Mon, May 22, 2023 at 10:42:04AM -0400, Sean Anderson wrote:

quoted

Have you had a chance to review this driver?

Partially / too little (and no, I don't have an answer yet). I am
debugging a SERDES protocol change procedure from XFI to SGMII.

I'd just like to reiterate that, like I said in the cover letter, I
believe this driver still has value even if it cannot yet perform
protocol switching.

Please send me your feedback, and I will try and incorporate it into the
next revision. Previously, you said you had major objections to the
contents of this series, but you still have not listed them.

And if SERDES protocol switching was not physically possible, would this
patch set still have value?

Yes. To e.g. set up SGMII25 or to fix the clocking situation.

--Sean