# Re: \[PATCH 8/9\] powerpc: Add HOTPLUG\_SMT support

- From: Thomas Gleixner \<hidden\>
- Date: 2023-06-12 16:35:12 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/06/2230259
- Thread: https://ratatoskr.run/linux-arch/2023/05/2208839/t.md

```text
On Mon, Jun 12 2023 at 17:20, Laurent Dufour wrote:
> On 10/06/2023 23:10:02, Thomas Gleixner wrote:
>> This needs more thoughts to avoid a completely inconsistent duct tape
>> mess.
>
> Despite the test against smt_enabled_at_boot, mentioned above, I can't see
> anything else to rework. Am I missing something?

See my comments on the core code changes.

>> Btw, the command line parser and the variable smt_enabled_at_boot being
>> type int allow negative number of threads too... Maybe not what you want.
>
> I do agree, it should an unsigned type.

I assume you'll fix that yourself. :)

Thanks,

        tglx
```
