Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

9 messages, 4 authors, 2023-06-15 · open the first message on its own page

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Randy Dunlap <hidden>
Date: 2023-06-02 20:56:37


On 6/1/23 21:01, Stephen Rothwell wrote:
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                 from ../include/linux/preempt.h:11,
                 from ../include/linux/spinlock.h:56,
                 from ../include/linux/mmzone.h:8,
                 from ../include/linux/gfp.h:7,
                 from ../include/linux/slab.h:15,
                 from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function 'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use in this function); did you mean 'zonelist'?
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
../include/linux/container_of.h:19:33: note: in definition of macro 'container_of'
   19 |         void *__mptr = (void *)(ptr);                                   \
      |                                 ^~~
../include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
../include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry'
  689 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
../arch/powerpc/kernel/iommu.c:1391:9: note: in expansion of macro 'list_for_each_entry'
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |         ^~~~~~~~~~~~~~~~~~~
../arch/powerpc/kernel/iommu.c:1391:36: note: each undeclared identifier is reported only once for each function it appears in
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
../include/linux/container_of.h:19:33: note: in definition of macro 'container_of'
   19 |         void *__mptr = (void *)(ptr);                                   \
      |                                 ^~~
../include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
../include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry'
  689 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
../arch/powerpc/kernel/iommu.c:1391:9: note: in expansion of macro 'list_for_each_entry'
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |         ^~~~~~~~~~~~~~~~~~~
In file included from ../include/linux/init.h:5,
                 from ../arch/powerpc/kernel/iommu.c:13:
./../include/linux/compiler_types.h:338:27: error: expression in static assertion is not an integer
  338 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
   78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
      |                                                        ^~~~
../include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
   20 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |         ^~~~~~~~~~~~~
../include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
   20 |         static_assert(__same_type(*(ptr), ((type *)0)->member) ||       \
      |                       ^~~~~~~~~~~
../include/linux/list.h:520:9: note: in expansion of macro 'container_of'
  520 |         container_of(ptr, type, member)
      |         ^~~~~~~~~~~~
../include/linux/list.h:531:9: note: in expansion of macro 'list_entry'
  531 |         list_entry((ptr)->next, type, member)
      |         ^~~~~~~~~~
../include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry'
  689 |         for (pos = list_first_entry(head, typeof(*pos), member);        \
      |                    ^~~~~~~~~~~~~~~~
../arch/powerpc/kernel/iommu.c:1391:9: note: in expansion of macro 'list_for_each_entry'
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |         ^~~~~~~~~~~~~~~~~~~


CONFIG_IOMMU_API=y
# CONFIG_IOMMU_SUPPORT is not set
CONFIG_IOMMU_HELPER=y


Full randconfig file is attached.

-- 
~Randy

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2023-06-04 00:23:08

Randy Dunlap [off-list ref] writes:
On 6/1/23 21:01, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                 from ../include/linux/preempt.h:11,
                 from ../include/linux/spinlock.h:56,
                 from ../include/linux/mmzone.h:8,
                 from ../include/linux/gfp.h:7,
                 from ../include/linux/slab.h:15,
                 from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function 'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use in this function); did you mean 'zonelist'?
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
...

hose_list is in pci-common.c which is built when PCI=y.

PSERIES and POWERNV force PCI=y.

But this config has neither:

# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set


Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.

cheers

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Timothy Pearson <tpearson@raptorengineering.com>
Date: 2023-06-04 04:06:08


----- Original Message -----
From: "Michael Ellerman" <mpe@ellerman.id.au>
To: "Randy Dunlap" <redacted>, "Stephen Rothwell" <redacted>, "Linux Next Mailing List"
[off-list ref]
Cc: "linux-kernel" <redacted>, "linuxppc-dev" <redacted>, "Alexey
Kardashevskiy" [off-list ref], "Timothy Pearson" [off-list ref]
Sent: Saturday, June 3, 2023 7:22:51 PM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
Randy Dunlap [off-list ref] writes:
quoted
On 6/1/23 21:01, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                 from ../include/linux/preempt.h:11,
                 from ../include/linux/spinlock.h:56,
                 from ../include/linux/mmzone.h:8,
                 from ../include/linux/gfp.h:7,
                 from ../include/linux/slab.h:15,
                 from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function
'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
in this function); did you mean 'zonelist'?
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
...

hose_list is in pci-common.c which is built when PCI=y.

PSERIES and POWERNV force PCI=y.

But this config has neither:

# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set


Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.

cheers
Sounds reasonable, I was going to look into this further over the weekend.  I can put together a patch for Monday if that works?

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Randy Dunlap <hidden>
Date: 2023-06-04 21:55:41


On 6/3/23 20:57, Timothy Pearson wrote:

----- Original Message -----
quoted
From: "Michael Ellerman" <mpe@ellerman.id.au>
To: "Randy Dunlap" <redacted>, "Stephen Rothwell" <redacted>, "Linux Next Mailing List"
[off-list ref]
Cc: "linux-kernel" <redacted>, "linuxppc-dev" <redacted>, "Alexey
Kardashevskiy" [off-list ref], "Timothy Pearson" [off-list ref]
Sent: Saturday, June 3, 2023 7:22:51 PM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Randy Dunlap [off-list ref] writes:
quoted
On 6/1/23 21:01, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                 from ../include/linux/preempt.h:11,
                 from ../include/linux/spinlock.h:56,
                 from ../include/linux/mmzone.h:8,
                 from ../include/linux/gfp.h:7,
                 from ../include/linux/slab.h:15,
                 from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function
'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
in this function); did you mean 'zonelist'?
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
...

hose_list is in pci-common.c which is built when PCI=y.

PSERIES and POWERNV force PCI=y.

But this config has neither:

# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set


Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.

cheers
Sounds reasonable, I was going to look into this further over the weekend.  I can put together a patch for Monday if that works?
Works for me. Go for it.
Thanks.

-- 
~Randy

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Randy Dunlap <hidden>
Date: 2023-06-15 16:00:25

Hi Timothy,

On 6/3/23 20:57, Timothy Pearson wrote:

----- Original Message -----
quoted
From: "Michael Ellerman" <mpe@ellerman.id.au>
To: "Randy Dunlap" <redacted>, "Stephen Rothwell" <redacted>, "Linux Next Mailing List"
[off-list ref]
Cc: "linux-kernel" <redacted>, "linuxppc-dev" <redacted>, "Alexey
Kardashevskiy" [off-list ref], "Timothy Pearson" [off-list ref]
Sent: Saturday, June 3, 2023 7:22:51 PM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Randy Dunlap [off-list ref] writes:
quoted
On 6/1/23 21:01, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                 from ../include/linux/preempt.h:11,
                 from ../include/linux/spinlock.h:56,
                 from ../include/linux/mmzone.h:8,
                 from ../include/linux/gfp.h:7,
                 from ../include/linux/slab.h:15,
                 from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function
'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
in this function); did you mean 'zonelist'?
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
...

hose_list is in pci-common.c which is built when PCI=y.

PSERIES and POWERNV force PCI=y.

But this config has neither:

# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set


Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.

cheers
Sounds reasonable, I was going to look into this further over the weekend.  I can put together a patch for Monday if that works?
Did you prepare a patch for this? I am still seeing this build error.

thanks.
-- 
~Randy

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Timothy Pearson <tpearson@raptorengineering.com>
Date: 2023-06-15 16:06:02


----- Original Message -----
From: "Randy Dunlap" <redacted>
To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Michael Ellerman" <mpe@ellerman.id.au>
Cc: "Stephen Rothwell" <redacted>, "Linux Next Mailing List" <redacted>, "linux-kernel"
[off-list ref], "linuxppc-dev" [off-list ref], "Alexey Kardashevskiy" [off-list ref]
Sent: Thursday, June 15, 2023 11:00:08 AM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
Hi Timothy,

On 6/3/23 20:57, Timothy Pearson wrote:
quoted

----- Original Message -----
quoted
From: "Michael Ellerman" <mpe@ellerman.id.au>
To: "Randy Dunlap" <redacted>, "Stephen Rothwell"
[off-list ref], "Linux Next Mailing List"
[off-list ref]
Cc: "linux-kernel" <redacted>, "linuxppc-dev"
[off-list ref], "Alexey
Kardashevskiy" [off-list ref], "Timothy Pearson"
[off-list ref]
Sent: Saturday, June 3, 2023 7:22:51 PM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Randy Dunlap [off-list ref] writes:
quoted
On 6/1/23 21:01, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                 from ../include/linux/preempt.h:11,
                 from ../include/linux/spinlock.h:56,
                 from ../include/linux/mmzone.h:8,
                 from ../include/linux/gfp.h:7,
                 from ../include/linux/slab.h:15,
                 from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function
'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
in this function); did you mean 'zonelist'?
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
...

hose_list is in pci-common.c which is built when PCI=y.

PSERIES and POWERNV force PCI=y.

But this config has neither:

# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set


Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.

cheers
Sounds reasonable, I was going to look into this further over the weekend.  I
can put together a patch for Monday if that works?
Did you prepare a patch for this? I am still seeing this build error.

thanks.
--
~Randy
Yes, it was sent in to the linuxppc-dev list some weeks ago.  Did it not arrive?

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Randy Dunlap <hidden>
Date: 2023-06-15 16:13:23


On 6/15/23 09:05, Timothy Pearson wrote:

----- Original Message -----
quoted
From: "Randy Dunlap" <redacted>
To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Michael Ellerman" <mpe@ellerman.id.au>
Cc: "Stephen Rothwell" <redacted>, "Linux Next Mailing List" <redacted>, "linux-kernel"
[off-list ref], "linuxppc-dev" [off-list ref], "Alexey Kardashevskiy" [off-list ref]
Sent: Thursday, June 15, 2023 11:00:08 AM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Hi Timothy,

On 6/3/23 20:57, Timothy Pearson wrote:
quoted

----- Original Message -----
quoted
From: "Michael Ellerman" <mpe@ellerman.id.au>
To: "Randy Dunlap" <redacted>, "Stephen Rothwell"
[off-list ref], "Linux Next Mailing List"
[off-list ref]
Cc: "linux-kernel" <redacted>, "linuxppc-dev"
[off-list ref], "Alexey
Kardashevskiy" [off-list ref], "Timothy Pearson"
[off-list ref]
Sent: Saturday, June 3, 2023 7:22:51 PM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Randy Dunlap [off-list ref] writes:
quoted
On 6/1/23 21:01, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                 from ../include/linux/preempt.h:11,
                 from ../include/linux/spinlock.h:56,
                 from ../include/linux/mmzone.h:8,
                 from ../include/linux/gfp.h:7,
                 from ../include/linux/slab.h:15,
                 from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function
'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
in this function); did you mean 'zonelist'?
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
...

hose_list is in pci-common.c which is built when PCI=y.

PSERIES and POWERNV force PCI=y.

But this config has neither:

# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set


Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.

cheers
Sounds reasonable, I was going to look into this further over the weekend.  I
can put together a patch for Monday if that works?
Did you prepare a patch for this? I am still seeing this build error.

thanks.
--
~Randy
Yes, it was sent in to the linuxppc-dev list some weeks ago.  Did it not arrive?
I don't know - I'm not subscribed to that list.

It's probably still in the patchworks review cycle
so it hasn't been applied anywhere that gets into linux-next.

thanks.
-- 
~Randy

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Randy Dunlap <hidden>
Date: 2023-06-15 16:34:58


On 6/15/23 09:13, Randy Dunlap wrote:

On 6/15/23 09:05, Timothy Pearson wrote:
quoted

----- Original Message -----
quoted
From: "Randy Dunlap" <redacted>
To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Michael Ellerman" <mpe@ellerman.id.au>
Cc: "Stephen Rothwell" <redacted>, "Linux Next Mailing List" <redacted>, "linux-kernel"
[off-list ref], "linuxppc-dev" [off-list ref], "Alexey Kardashevskiy" [off-list ref]
Sent: Thursday, June 15, 2023 11:00:08 AM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Hi Timothy,

On 6/3/23 20:57, Timothy Pearson wrote:
quoted

----- Original Message -----
quoted
From: "Michael Ellerman" <mpe@ellerman.id.au>
To: "Randy Dunlap" <redacted>, "Stephen Rothwell"
[off-list ref], "Linux Next Mailing List"
[off-list ref]
Cc: "linux-kernel" <redacted>, "linuxppc-dev"
[off-list ref], "Alexey
Kardashevskiy" [off-list ref], "Timothy Pearson"
[off-list ref]
Sent: Saturday, June 3, 2023 7:22:51 PM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Randy Dunlap [off-list ref] writes:
quoted
On 6/1/23 21:01, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                 from ../include/linux/preempt.h:11,
                 from ../include/linux/spinlock.h:56,
                 from ../include/linux/mmzone.h:8,
                 from ../include/linux/gfp.h:7,
                 from ../include/linux/slab.h:15,
                 from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function
'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
in this function); did you mean 'zonelist'?
 1391 |         list_for_each_entry(hose, &hose_list, list_node) {
      |                                    ^~~~~~~~~
...

hose_list is in pci-common.c which is built when PCI=y.

PSERIES and POWERNV force PCI=y.

But this config has neither:

# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set


Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.

cheers
Sounds reasonable, I was going to look into this further over the weekend.  I
can put together a patch for Monday if that works?
Did you prepare a patch for this? I am still seeing this build error.

thanks.
--
~Randy
Yes, it was sent in to the linuxppc-dev list some weeks ago.  Did it not arrive?
I don't know - I'm not subscribed to that list.

It's probably still in the patchworks review cycle
so it hasn't been applied anywhere that gets into linux-next.
OK, it's here, mark with Success:
http://patchwork.ozlabs.org/project/linuxppc-dev/patch/2015925968.3546872.1685990936823.JavaMail.zimbra@raptorengineeringinc.com/

I don't know what happens to it next or when.

thanks.

-- 
~Randy

Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)

From: Christophe Leroy <hidden>
Date: 2023-06-15 22:46:50


Le 15/06/2023 à 18:34, Randy Dunlap a écrit :

On 6/15/23 09:13, Randy Dunlap wrote:
quoted

On 6/15/23 09:05, Timothy Pearson wrote:
quoted

----- Original Message -----
quoted
From: "Randy Dunlap" <redacted>
To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Michael Ellerman" <mpe@ellerman.id.au>
Cc: "Stephen Rothwell" <redacted>, "Linux Next Mailing List" <redacted>, "linux-kernel"
[off-list ref], "linuxppc-dev" [off-list ref], "Alexey Kardashevskiy" [off-list ref]
Sent: Thursday, June 15, 2023 11:00:08 AM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Hi Timothy,

On 6/3/23 20:57, Timothy Pearson wrote:
quoted

----- Original Message -----
quoted
From: "Michael Ellerman" <mpe@ellerman.id.au>
To: "Randy Dunlap" <redacted>, "Stephen Rothwell"
[off-list ref], "Linux Next Mailing List"
[off-list ref]
Cc: "linux-kernel" <redacted>, "linuxppc-dev"
[off-list ref], "Alexey
Kardashevskiy" [off-list ref], "Timothy Pearson"
[off-list ref]
Sent: Saturday, June 3, 2023 7:22:51 PM
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
quoted
Randy Dunlap [off-list ref] writes:
quoted
On 6/1/23 21:01, Stephen Rothwell wrote:
quoted
Hi all,

Changes since 20230601:
On powerpc64, a randconfig failed with:

In file included from ../include/linux/list.h:5,
                  from ../include/linux/preempt.h:11,
                  from ../include/linux/spinlock.h:56,
                  from ../include/linux/mmzone.h:8,
                  from ../include/linux/gfp.h:7,
                  from ../include/linux/slab.h:15,
                  from ../arch/powerpc/kernel/iommu.c:15:
../arch/powerpc/kernel/iommu.c: In function
'spapr_tce_setup_phb_iommus_initcall':
../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
in this function); did you mean 'zonelist'?
  1391 |         list_for_each_entry(hose, &hose_list, list_node) {
       |                                    ^~~~~~~~~
...

hose_list is in pci-common.c which is built when PCI=y.

PSERIES and POWERNV force PCI=y.

But this config has neither:

# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_HAVE_PCI=y
# CONFIG_PCI is not set
# CONFIG_COMMON_CLK_RS9_PCIE is not set


Probably the spapr_tce code should be wrapped in an #ifdef that is only
enabled when POWERNV || PSERIES is enabled.

cheers
Sounds reasonable, I was going to look into this further over the weekend.  I
can put together a patch for Monday if that works?
Did you prepare a patch for this? I am still seeing this build error.

thanks.
--
~Randy
Yes, it was sent in to the linuxppc-dev list some weeks ago.  Did it not arrive?
I don't know - I'm not subscribed to that list.

It's probably still in the patchworks review cycle
so it hasn't been applied anywhere that gets into linux-next.
OK, it's here, mark with Success:
http://patchwork.ozlabs.org/project/linuxppc-dev/patch/2015925968.3546872.1685990936823.JavaMail.zimbra@raptorengineeringinc.com/

I don't know what happens to it next or when.
Is that supposed to fix anything ? I doesn't have any Fixes: tag

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help