# Re: \[PATCH 01/10\] watchdog/hardlockup: Keep kernel.nmi\_watchdog sysctl as 0444 if probe fails

- From: Petr Mladek \<pmladek@suse.com\>
- Date: 2023-05-30 14:16:11 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/05/2214761
- Thread: https://ratatoskr.run/linuxppc-dev/2023/05/2211972/t.md

```text
On Fri 2023-05-26 18:41:31, Douglas Anderson wrote:
> The permissions for the kernel.nmi_watchdog sysctl have always been
> set at compile time despite the fact that a watchdog can fail to
> probe. Let's fix this and set the permissions based on whether the
> hardlockup detector actually probed.
> 
> Fixes: a994a3147e4c ("watchdog/hardlockup/perf: Implement init time detection of perf")
> Reported-by: Petr Mladek <pmladek@suse.com>
> Closes: https://lore.kernel.org/r/ZHCn4hNxFpY5-9Ki@alley
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Looks good to me:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr
```