[PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function

Subsystems: freescale quicc engine library, freescale soc drivers, the rest

STALE1263d

2 messages, 2 authors, 2023-03-20 · open the first message on its own page

[PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function

From: Tom Rix <trix@redhat.com>
Date: 2023-03-19 15:39:02

clang with W=1 reports
drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function
  'qe_ic_from_irq' [-Werror,-Wunused-function]
static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
                            ^
This function is not used, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/soc/fsl/qe/qe_ic.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
index bbae3d39c7be..c0b4f865fba9 100644
--- a/drivers/soc/fsl/qe/qe_ic.c
+++ b/drivers/soc/fsl/qe/qe_ic.c
@@ -232,11 +232,6 @@ static inline void qe_ic_write(__be32  __iomem *base, unsigned int reg,
 	iowrite32be(value, base + (reg >> 2));
 }
 
-static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
-{
-	return irq_get_chip_data(virq);
-}
-
 static inline struct qe_ic *qe_ic_from_irq_data(struct irq_data *d)
 {
 	return irq_data_get_irq_chip_data(d);
-- 
2.27.0

Re: [PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function

From: Christophe Leroy <hidden>
Date: 2023-03-20 07:14:24


Le 19/03/2023 à 16:37, Tom Rix a écrit :
clang with W=1 reports
drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function
   'qe_ic_from_irq' [-Werror,-Wunused-function]
static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
                             ^
This function is not used, so remove it.
You should mention that it is not used anymore since commit d7c2878cfcfa 
("soc: fsl: qe: remove unused qe_ic_set_* functions")
quoted hunk
Signed-off-by: Tom Rix <trix@redhat.com>
---
  drivers/soc/fsl/qe/qe_ic.c | 5 -----
  1 file changed, 5 deletions(-)
diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
index bbae3d39c7be..c0b4f865fba9 100644
--- a/drivers/soc/fsl/qe/qe_ic.c
+++ b/drivers/soc/fsl/qe/qe_ic.c
@@ -232,11 +232,6 @@ static inline void qe_ic_write(__be32  __iomem *base, unsigned int reg,
  	iowrite32be(value, base + (reg >> 2));
  }
  
-static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
-{
-	return irq_get_chip_data(virq);
-}
-
  static inline struct qe_ic *qe_ic_from_irq_data(struct irq_data *d)
  {
  	return irq_data_get_irq_chip_data(d);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help