# \[PATCH v3\] macintosh: via-pmu-led: fix Kconfig for ADB\_PMU\_LED\_DISK - From: Randy Dunlap \ - Date: 2023-02-23 17:20:16 - List: linuxppc-dev - Page: https://ratatoskr.run/linuxppc-dev/2023/02/2111432 - Thread: https://ratatoskr.run/linuxppc-dev/2023/02/2111432/t.md ```text LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK when ATA is not set/enabled causes a Kconfig warning: WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n] Selected by [y]: - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y] Fix this by making ADB_PMU_LED_DISK depend on LEDS_TRIGGER_DISK instead of selecting it. Seen on both PPC32 and PPC64. Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected") Signed-off-by: Randy Dunlap Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Elimar Riesebieter Cc: Michael Ellerman Cc: --- v2: add a complete Subject: line v3: change select to depends on (Michael) drivers/macintosh/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig --- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig @@ -88,8 +88,7 @@ config ADB_PMU_LED_DISK bool "Use front LED as DISK LED by default" depends on ADB_PMU_LED depends on LEDS_CLASS - select LEDS_TRIGGERS - select LEDS_TRIGGER_DISK + depends on LEDS_TRIGGER_DISK help This option makes the front LED default to the disk trigger so that it blinks on disk activity. ```