# Re: \[PATCH v6 24/26\] powerpc/pseries: Implement secvars for dynamic secure boot

- From: Michael Ellerman \<hidden\>
- Date: 2023-02-13 05:27:18 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/02/2099335
- Thread: https://ratatoskr.run/linuxppc-dev/2023/02/2097444/t.md

```text
Andrew Donnellan [ref] writes:
> On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote:
>> > > +err:
>> > > +    kfree(var.data);
>> > 
>> > remove the kfree()
>> 
>> Actually don't remove it but it should probably be
>> 
>> if (var.data != &version)
>>      kfree(var.data);
>> 
>
> Argh, thanks for catching this.
>
> I don't think the condition is needed - we can assume the var.data is
> unmodified.
>
> mpe, are you able to fix this up in merge?

Yeah, can you reply here with the delta you want applied.

cheers
```
