# Re: \[PATCH 2/4\] powerpc/pseries: Fix alignment of PLPKS structures and buffers

- From: Russell Currey \<hidden\>
- Date: 2023-01-04 03:47:58 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/01/9529544
- Thread: https://ratatoskr.run/linuxppc-dev/2022/12/9529497/t.md

```text
On Tue, 2022-12-20 at 18:16 +1100, Andrew Donnellan wrote:
> A number of structures and buffers passed to PKS hcalls have
> alignment
> requirements, which could on occasion cause problems:
> 
> - Authorisation structures must be 16-byte aligned and must not cross
> a
>   page boundary
> 
> - Label structures must not cross page coundaries
> 
> - Password output buffers must not cross page boundaries
> 
> Round up the allocations of these structures/buffers to the next
> power of
> 2 to make sure this happens.
> 
> Reported-by: Benjamin Gray <redacted>
> Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform
> KeyStore")
> Signed-off-by: Andrew Donnellan <redacted>
> 
Reviewed-by: Russell Currey <redacted>

```
