# Re: \[PATCH 02/15\] video: fbdev: atyfb: Introduce backlight\_get\_brightness()

- From: Sam Ravnborg \<hidden\>
- Date: 2023-01-09 18:23:39 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2023/01/2060084
- Thread: https://ratatoskr.run/linux-fbdev/2023/01/2058457/t.md

```text
Hi Christophe,
On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote:
> 
> 
> Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit :
> > From: Sam Ravnborg <redacted>
> > 
> > Introduce backlight_get_brightness() to simplify logic
> > and avoid direct access to backlight properties.
> 
> When I read 'introduce' I understand that you are adding a new function.
> 
> In fact backlight_get_brightness() already exists, so maybe replace 
> 'introduce' by 'use'

Thanks for your feedback. A similar patch is already applied to the
fbdev tree, so this patch can be ignored.

	Sam
```