[PATCH] powerpc/kexec_file: print error string on usable memory property update failure

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1273d LANDED

Landed in mainline as b0ae5b6f3c29 on 2023-02-15.

5 messages, 3 authors, 2023-02-20 · open the first message on its own page

[PATCH] powerpc/kexec_file: print error string on usable memory property update failure

From: Sourabh Jain <hidden>
Date: 2022-12-16 12:28:18 

Print the FDT error description along with the error message if failed
to set the "linux,drconf-usable-memory" property in the kdump kernel's
FDT.

Signed-off-by: Sourabh Jain <redacted>
---
 arch/powerpc/kexec/file_load_64.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c
index 349a781cea0b3..7602f7e1e634e 100644
--- a/arch/powerpc/kexec/file_load_64.c
+++ b/arch/powerpc/kexec/file_load_64.c
@@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem)
 		ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory",
 				  um_info.buf, (um_info.idx * sizeof(u64)));
 		if (ret) {
-			pr_err("Failed to update fdt with linux,drconf-usable-memory property");
+			pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s",
+			       fdt_strerror(ret));
 			goto out;
 		}
 	}
-- 
2.38.1

Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure

From: Hari Bathini <hbathini@linux.ibm.com>
Date: 2022-12-19 08:47:24 


On 16/12/22 5:57 pm, Sourabh Jain wrote:
Print the FDT error description along with the error message if failed
to set the "linux,drconf-usable-memory" property in the kdump kernel's
FDT.

Signed-off-by: Sourabh Jain <redacted>
LGTM

Acked-by: Hari Bathini <hbathini@linux.ibm.com>
quoted hunk
---
  arch/powerpc/kexec/file_load_64.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c
index 349a781cea0b3..7602f7e1e634e 100644
--- a/arch/powerpc/kexec/file_load_64.c
+++ b/arch/powerpc/kexec/file_load_64.c
@@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem)
  		ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory",
  				  um_info.buf, (um_info.idx * sizeof(u64)));
  		if (ret) {
-			pr_err("Failed to update fdt with linux,drconf-usable-memory property");
+			pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s",
+			       fdt_strerror(ret));
  			goto out;
  		}
  	}

Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure

From: Sourabh Jain <hidden>
Date: 2022-12-21 05:40:07 

On 19/12/22 14:16, Hari Bathini wrote:

On 16/12/22 5:57 pm, Sourabh Jain wrote:
quoted
Print the FDT error description along with the error message if failed
to set the "linux,drconf-usable-memory" property in the kdump kernel's
FDT.

Signed-off-by: Sourabh Jain <redacted>
LGTM

Acked-by: Hari Bathini <hbathini@linux.ibm.com>
Thanks!

- Sourabh Jain

Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure

From: Sourabh Jain <hidden>
Date: 2023-02-01 04:48:56 

The only place on kexec/kdump path where we don't print
reason for FDT operation failure. This patch fix that.

Will this be a good candidate for next rc?

Thanks,
Sourabh

On 16/12/22 17:57, Sourabh Jain wrote:
quoted hunk
Print the FDT error description along with the error message if failed
to set the "linux,drconf-usable-memory" property in the kdump kernel's
FDT.

Signed-off-by: Sourabh Jain <redacted>
---
  arch/powerpc/kexec/file_load_64.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c
index 349a781cea0b3..7602f7e1e634e 100644
--- a/arch/powerpc/kexec/file_load_64.c
+++ b/arch/powerpc/kexec/file_load_64.c
@@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem)
  		ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory",
  				  um_info.buf, (um_info.idx * sizeof(u64)));
  		if (ret) {
-			pr_err("Failed to update fdt with linux,drconf-usable-memory property");
+			pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s",
+			       fdt_strerror(ret));
  			goto out;
  		}
  	}

Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure

From: Michael Ellerman <hidden>
Date: 2023-02-20 03:55:38 

On Fri, 16 Dec 2022 17:57:08 +0530, Sourabh Jain wrote:
Print the FDT error description along with the error message if failed
to set the "linux,drconf-usable-memory" property in the kdump kernel's
FDT.

Applied to powerpc/next.

[1/1] powerpc/kexec_file: print error string on usable memory property update failure
      https://git.kernel.org/powerpc/c/b0ae5b6f3c298a005b73556740526c0e24a5633c

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help