# \[PATCH v2\] powerpc/83xx/mpc832x\_rdb: call platform\_device\_put() in error case in of\_fsl\_spi\_probe()

- From: Yang Yingliang \<hidden\>
- Date: 2022-10-29 11:18:43 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2022/10/9528859
- Thread: https://ratatoskr.run/linuxppc-dev/2022/10/9528859/t.md

```text
If platform_device_add() is not called or failed, it can not call
platform_device_del() to clean up memory, it should call
platform_device_put() in error case.

Fixes: 26f6cb999366 ("[POWERPC] fsl_soc: add support for fsl_spi")
Signed-off-by: Yang Yingliang <redacted>
---
v1 -> v2:
  Correct fix tag.
  v1 link:
  https://lore.kernel.org/lkml/20220701094543.2326927-1-yangyingliang@huawei.com/
---
 arch/powerpc/platforms/83xx/mpc832x_rdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/83xx/mpc832x_rdb.c b/arch/powerpc/platforms/83xx/mpc832x_rdb.c
index e12cb44e717f..caa96edf0e72 100644
--- a/arch/powerpc/platforms/83xx/mpc832x_rdb.c
+++ b/arch/powerpc/platforms/83xx/mpc832x_rdb.c
@@ -107,7 +107,7 @@ static int __init of_fsl_spi_probe(char *type, char *compatible, u32 sysclk,
 
 		goto next;
 unreg:
-		platform_device_del(pdev);
+		platform_device_put(pdev);
 err:
 		pr_err("%pOF: registration failed\n", np);
 next:
-- 
2.25.1

```