[PATCH -next] tty: hvc: make hvc_rtas_dev static

Subsystems: hypervisor virtual console driver, the rest, tty layer and serial drivers

STALE1467d LANDED

Landed in mainline as cc72a1eea5e3 on 2022-11-03.

2 messages, 2 authors, 2022-10-20 · open the first message on its own page

[PATCH -next] tty: hvc: make hvc_rtas_dev static

From: ruanjinjie <hidden>
Date: 2022-10-19 06:47:57

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
not declared. Should it be static?

Signed-off-by: ruanjinjie <redacted>
---
 drivers/tty/hvc/hvc_rtas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
index e8b8c645482b..184d325abeed 100644
--- a/drivers/tty/hvc/hvc_rtas.c
+++ b/drivers/tty/hvc/hvc_rtas.c
@@ -26,7 +26,7 @@
 #include "hvc_console.h"
 
 #define hvc_rtas_cookie 0x67781e15
-struct hvc_struct *hvc_rtas_dev;
+static struct hvc_struct *hvc_rtas_dev;
 
 static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
 static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;
-- 
2.25.1

Re: [PATCH -next] tty: hvc: make hvc_rtas_dev static

From: Jiri Slaby <jirislaby@kernel.org>
Date: 2022-10-20 05:29:42

On 19. 10. 22, 8:44, ruanjinjie wrote:
The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
not declared. Should it be static?
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
quoted hunk
Signed-off-by: ruanjinjie <redacted>
---
  drivers/tty/hvc/hvc_rtas.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
index e8b8c645482b..184d325abeed 100644
--- a/drivers/tty/hvc/hvc_rtas.c
+++ b/drivers/tty/hvc/hvc_rtas.c
@@ -26,7 +26,7 @@
  #include "hvc_console.h"
  
  #define hvc_rtas_cookie 0x67781e15
-struct hvc_struct *hvc_rtas_dev;
+static struct hvc_struct *hvc_rtas_dev;
  
  static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
  static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;
-- 
js
suse labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help