# Re: \[PATCH v2 37/44\] arm,omap2: Use WFI for omap2\_pm\_idle()

- From: Tony Lindgren \<tony@atomide.com\>
- Date: 2022-09-27 06:22:06 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2022/09/1947578
- Thread: https://ratatoskr.run/linux-alpha/2022/09/1937379/t/2.md

```text
* Peter Zijlstra [ref] [220919 10:09]:
> arch_cpu_idle() is a very simple idle interface and exposes only a
> single idle state and is expected to not require RCU and not do any
> tracing/instrumentation.
> 
> As such, omap2_pm_idle() is not a valid implementation. Replace it
> with a simple (shallow) omap2_do_wfi() call.
> 
> Omap2 doesn't have a cpuidle driver; but adding one would be the
> recourse to (re)gain the other idle states.

Looks good to me thanks:

Acked-by: Tony Lindgren <tony@atomide.com>
```
