[PATCH] powerpc: 44x: Add of_node_put() when break out from for_each

Subsystems: linux for powerpc (32-bit and 64-bit), linux for powerpc embedded ppc4xx, the rest

STALE1458d LANDED

Landed in mainline as 9d86f0919544 on 2022-09-05.

2 messages, 2 authors, 2022-09-09 · open the first message on its own page

[PATCH] powerpc: 44x: Add of_node_put() when break out from for_each

From: Liang He <hidden>
Date: 2022-07-01 13:32:21

In ppc47x_init_irq(), we need to call of_node_put() when there is
a break during the iteration of for_each_node_with_property() which
will automatically increase and decrease the refcount.

Signed-off-by: Liang He <redacted>
---
 arch/powerpc/platforms/44x/ppc476.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/44x/ppc476.c b/arch/powerpc/platforms/44x/ppc476.c
index 20cc8f80b086..7d9075fb20c9 100644
--- a/arch/powerpc/platforms/44x/ppc476.c
+++ b/arch/powerpc/platforms/44x/ppc476.c
@@ -140,6 +140,7 @@ static void __init ppc47x_init_irq(void)
 		ppc_md.get_irq = mpic_get_irq;
 	} else
 		panic("Unrecognized top level interrupt controller");
+	of_node_put(np);
 }
 
 #ifdef CONFIG_SMP
-- 
2.25.1

Re: [PATCH] powerpc: 44x: Add of_node_put() when break out from for_each

From: Michael Ellerman <hidden>
Date: 2022-09-09 12:14:45

On Fri, 1 Jul 2022 21:31:26 +0800, Liang He wrote:
In ppc47x_init_irq(), we need to call of_node_put() when there is
a break during the iteration of for_each_node_with_property() which
will automatically increase and decrease the refcount.
Applied to powerpc/next.

[1/1] powerpc: 44x: Add of_node_put() when break out from for_each
      https://git.kernel.org/powerpc/c/9d86f0919544d8e422be2a1d562de1dbbbb6052d

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help