-----邮件原件-----
发件人: Christophe Leroy [off-list ref] 
发送时间: 2022年5月28日 15:03
收件人: 王文虎 [off-list ref]; kernel@vivo.com
抄送: Greg Kroah-Hartman [off-list ref]; Arnd Bergmann [off-list ref]; Scott Wood [off-list ref]; Michael Ellerman [off-list ref]; Randy Dunlap [off-list ref]; linuxppc-dev@lists.ozlabs.org
主题: Re: [PATCH v4,1/5] powerpc: sysdev: fix compile error for fsl_85xx_l2ctlr



Le 15/03/2022 à 13:45, Christophe Leroy a écrit :

Le 24/04/2020 à 10:58, Wang Wenhu a écrit :

quoted

Include "linux/of_address.h" to fix the compile error for
mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c.

   CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function
‘mpc85xx_l2ctlr_of_probe’:
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit 
declaration of function ‘of_iomap’; did you mean ‘pci_iomap’?
[-Werror=implicit-function-declaration]
   l2ctlr = of_iomap(dev->dev.of_node, 0);
            ^~~~~~~~
            pci_iomap
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes 
pointer from integer without a cast [-Werror=int-conversion]
   l2ctlr = of_iomap(dev->dev.of_node, 0);
          ^
cc1: all warnings being treated as errors
scripts/Makefile.build:267: recipe for target 
'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed
make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Christophe Leroy <redacted>
Cc: Scott Wood <oss@buserror.net>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Randy Dunlap <redacted>
Cc: linuxppc-dev@lists.ozlabs.org
Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
Reviewed-by: Christophe Leroy <redacted>
Signed-off-by: Wang Wenhu <redacted>

Is there still an interest for this series ?

I see there is even a v5 at
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=172421&
state=* allthough I can't find it in my emails.

If so do you plan to send any update of it at some point ?

Otherwise, as CONFIG_FSL_85XX_CACHE_SRAM is not user selectable and no 
driver selects it, I think time has come to remove it completely.

Thanks for the reference. As the v5 series failed to reach a appointment,  we currently
use it out of tree. I would try a new version with the whole driver implemented in UIO module.
So it's ok to remove the version here.

CONFIG_FSL_85XX_CACHE_SRAM has now been removed.

See
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=dc21ed2aef4150fc2fcf58227a4ff24502015c03