# Re: \[PATCH v6 13/29\] iommu/amd: Compose MSI messages for NMI irqs in non-IR format

- From: Ricardo Neri \<hidden\>
- Date: 2022-05-13 18:59:53 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2022/05/1781650
- Thread: https://ratatoskr.run/linuxppc-dev/2022/05/1771745/t.md

```text
On Fri, May 06, 2022 at 11:31:56PM +0200, Thomas Gleixner wrote:
> On Thu, May 05 2022 at 16:59, Ricardo Neri wrote:
> > +	 *
> > +	 * Also, NMIs do not have an associated vector. No need for cleanup.
> 
> They have a vector and what the heck is this cleanup comment for here?
> There is nothing cleanup alike anywhere near.
> 
> Adding confusing comments is worse than adding no comments at all.

I will remove the comment regarding cleanup. I will clarify that NMI has a
fixed vector.

Thanks and BR,
Ricardo
```
