[PATCH -next] powerpc/iommu: Add missing of_node_put in iommu_init_early_dart

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1534d LANDED

Landed in mainline as 57b742a5b894 on 2022-05-22.

2 messages, 2 authors, 2022-05-24 · open the first message on its own page

[PATCH -next] powerpc/iommu: Add missing of_node_put in iommu_init_early_dart

From: Peng Wu <hidden>
Date: 2022-04-25 08:36:34

The device_node pointer is returned by of_find_compatible_node
with refcount incremented. We should use of_node_put() to avoid
the refcount leak.

Signed-off-by: Peng Wu <redacted>
---
 arch/powerpc/sysdev/dart_iommu.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/sysdev/dart_iommu.c b/arch/powerpc/sysdev/dart_iommu.c
index be6b99b1b352..9a02aed886a0 100644
--- a/arch/powerpc/sysdev/dart_iommu.c
+++ b/arch/powerpc/sysdev/dart_iommu.c
@@ -404,9 +404,10 @@ void __init iommu_init_early_dart(struct pci_controller_ops *controller_ops)
 	}
 
 	/* Initialize the DART HW */
-	if (dart_init(dn) != 0)
+	if (dart_init(dn) != 0) {
+		of_node_put(dn);
 		return;
-
+	}
 	/*
 	 * U4 supports a DART bypass, we use it for 64-bit capable devices to
 	 * improve performance.  However, that only works for devices connected
@@ -419,6 +420,7 @@ void __init iommu_init_early_dart(struct pci_controller_ops *controller_ops)
 
 	/* Setup pci_dma ops */
 	set_pci_dma_ops(&dma_iommu_ops);
+	of_node_put(dn);
 }
 
 #ifdef CONFIG_PM
-- 
2.17.1

Re: [PATCH -next] powerpc/iommu: Add missing of_node_put in iommu_init_early_dart

From: Michael Ellerman <hidden>
Date: 2022-05-24 11:16:58

On Mon, 25 Apr 2022 08:12:45 +0000, Peng Wu wrote:
The device_node pointer is returned by of_find_compatible_node
with refcount incremented. We should use of_node_put() to avoid
the refcount leak.
Applied to powerpc/next.

[1/1] powerpc/iommu: Add missing of_node_put in iommu_init_early_dart
      https://git.kernel.org/powerpc/c/57b742a5b8945118022973e6416b71351df512fb

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help