# Re: \[PATCH v2 09/13\] powerpc/ftrace: Implement CONFIG\_DYNAMIC\_FTRACE\_WITH\_ARGS

- From: Sven Schnelle \<svens@linux.ibm.com\>
- Date: 2022-02-16 13:27:50 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2022/02/1673482
- Thread: https://ratatoskr.run/linux-s390/2022/02/1673482/t.md

```text
Heiko Carstens [ref] writes:

> So, the in both variants s390 provides nearly identical data. The only
> difference is that for FL_SAVE_REGS the program status word mask is
> missing; therefore it is not possible to figure out the condition code
> or if interrupts were enabled/disabled.
>
> Vasily, Sven, I think we have two options here:
>
> - don't provide sane psw mask contents at all and say (again) that
>   ptregs contents are identical
>
> - provide (finally) a full psw mask contents using epsw, and indicate
>   validity with a flags bit in pt_regs
>
> I would vote for the second option, even though epsw is slow. But this
> is about the third or fourth time this came up in different
> contexts. So I'd guess we should go for the slow but complete
> solution. Opinions?

Given that this only affects ftrace_regs_caller, i would also vote for the
second option.
```
