[PATCH]selftests/powerpc: skip tests for unavailable mitigations.

STALE1716d LANDED

Landed in mainline as 18678591846d on 2021-12-16.

4 messages, 4 authors, 2021-12-21 · open the first message on its own page

[PATCH]selftests/powerpc: skip tests for unavailable mitigations.

From: Sachin Sant <hidden>
Date: 2021-12-13 16:43:16

Mitigation patching test iterates over a set of mitigations irrespective
of whether a certain mitigation is supported/available in the kernel.
This causes following messages on a kernel where some mitigations
are unavailable:

  Spawned threads enabling/disabling mitigations ...
  cat: entry_flush: No such file or directory
  cat: uaccess_flush: No such file or directory
  Waiting for timeout ...
  OK

This patch adds a check for available mitigations in the kernel.

Reported-by: Nageswara R Sastry <redacted>
Signed-off-by: Sachin Sant <redacted>
---
diff -Naurp aa/tools/testing/selftests/powerpc/security/mitigation-patching.sh bb/tools/testing/selftests/powerpc/security/mitigation-patching.sh
--- aa/tools/testing/selftests/powerpc/security/mitigation-patching.sh	2021-12-13 10:17:05.714127154 -0500
+++ bb/tools/testing/selftests/powerpc/security/mitigation-patching.sh	2021-12-13 10:19:32.575315913 -0500
@@ -44,7 +44,10 @@ mitigations="barrier_nospec stf_barrier
 
 for m in $mitigations
 do
-    do_one "$m" &
+    if [[ -f /sys/kernel/debug/powerpc/$m ]]
+    then
+        do_one "$m" &
+    fi
 done
 
 echo "Spawned threads enabling/disabling mitigations ..."

Re: [PATCH]selftests/powerpc: skip tests for unavailable mitigations.

From: Nageswara Sastry <hidden>
Date: 2021-12-14 04:28:02


On 13/12/21 10:12 pm, Sachin Sant wrote:
Mitigation patching test iterates over a set of mitigations irrespective
of whether a certain mitigation is supported/available in the kernel.
This causes following messages on a kernel where some mitigations
are unavailable:

   Spawned threads enabling/disabling mitigations ...
   cat: entry_flush: No such file or directory
   cat: uaccess_flush: No such file or directory
   Waiting for timeout ...
   OK

This patch adds a check for available mitigations in the kernel.

Reported-by: Nageswara R Sastry <redacted>
Signed-off-by: Sachin Sant <redacted>
Tested-by: Nageswara R Sastry <redacted>
quoted hunk
---
diff -Naurp aa/tools/testing/selftests/powerpc/security/mitigation-patching.sh bb/tools/testing/selftests/powerpc/security/mitigation-patching.sh
--- aa/tools/testing/selftests/powerpc/security/mitigation-patching.sh	2021-12-13 10:17:05.714127154 -0500
+++ bb/tools/testing/selftests/powerpc/security/mitigation-patching.sh	2021-12-13 10:19:32.575315913 -0500
@@ -44,7 +44,10 @@ mitigations="barrier_nospec stf_barrier
  
  for m in $mitigations
  do
-    do_one "$m" &
+    if [[ -f /sys/kernel/debug/powerpc/$m ]]
+    then
+        do_one "$m" &
+    fi
  done
  
  echo "Spawned threads enabling/disabling mitigations ..."
-- 
Thanks and Regards
R.Nageswara Sastry

Re: [PATCH]selftests/powerpc: skip tests for unavailable mitigations.

From: Russell Currey <hidden>
Date: 2021-12-15 04:36:52

On Mon, 2021-12-13 at 22:12 +0530, Sachin Sant wrote:
Mitigation patching test iterates over a set of mitigations
irrespective
of whether a certain mitigation is supported/available in the kernel.
This causes following messages on a kernel where some mitigations
are unavailable:

  Spawned threads enabling/disabling mitigations ...
  cat: entry_flush: No such file or directory
  cat: uaccess_flush: No such file or directory
  Waiting for timeout ...
  OK

This patch adds a check for available mitigations in the kernel.

Reported-by: Nageswara R Sastry <redacted>
Signed-off-by: Sachin Sant <redacted>
Reviewed-by: Russell Currey <redacted>

Re: [PATCH]selftests/powerpc: skip tests for unavailable mitigations.

From: Michael Ellerman <hidden>
Date: 2021-12-21 12:16:13

On Mon, 13 Dec 2021 22:12:23 +0530, Sachin Sant wrote:
Mitigation patching test iterates over a set of mitigations irrespective
of whether a certain mitigation is supported/available in the kernel.
This causes following messages on a kernel where some mitigations
are unavailable:

  Spawned threads enabling/disabling mitigations ...
  cat: entry_flush: No such file or directory
  cat: uaccess_flush: No such file or directory
  Waiting for timeout ...
  OK

[...]
Applied to powerpc/next.

[1/1] selftests/powerpc: skip tests for unavailable mitigations.
      https://git.kernel.org/powerpc/c/18678591846d668649fbd4f87b4a4c470818d386

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help