Dear Benjamin, dear Paul, dear Michael,
with commit 48b545b8018d ("powerpc/microwatt: Use standard 16550 UART
for console"), you have some code in arch/powerpc/kernel/udbg_16550.c,
conditional on the Kconfig symbol PPC_EARLY_DEBUG_MICROWATT. However,
since then, the definition of this Kconfig symbol was never introduced
to the mainline repository or current linux-next, nor am I finding any
pending patch for that.
Are you going to add this config definition soon? Or did you identify
that this setup code in udbg_16550.c is not actually needed and can we
simply drop this code again?
This issue was identified with the script ./scripts/checkkconfigsymbols.py.
Best regards,
Lukas
Le 23/12/2021 à 11:21, Lukas Bulwahn a écrit :
Dear Benjamin, dear Paul, dear Michael,
with commit 48b545b8018d ("powerpc/microwatt: Use standard 16550 UART
for console"), you have some code in arch/powerpc/kernel/udbg_16550.c,
conditional on the Kconfig symbol PPC_EARLY_DEBUG_MICROWATT. However,
since then, the definition of this Kconfig symbol was never introduced
to the mainline repository or current linux-next, nor am I finding any
pending patch for that.
Are you going to add this config definition soon? Or did you identify
that this setup code in udbg_16550.c is not actually needed and can we
simply drop this code again?
This issue was identified with the script ./scripts/checkkconfigsymbols.py.
Was it forgotten when handling comments to
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20200509050340.GD1464954@thinks.paulus.ozlabs.org/
?
Christophe Leroy [off-list ref] writes:
Le 23/12/2021 à 11:21, Lukas Bulwahn a écrit :
quoted
Dear Benjamin, dear Paul, dear Michael,
with commit 48b545b8018d ("powerpc/microwatt: Use standard 16550 UART
for console"), you have some code in arch/powerpc/kernel/udbg_16550.c,
conditional on the Kconfig symbol PPC_EARLY_DEBUG_MICROWATT. However,
since then, the definition of this Kconfig symbol was never introduced
to the mainline repository or current linux-next, nor am I finding any
pending patch for that.
Are you going to add this config definition soon? Or did you identify
that this setup code in udbg_16550.c is not actually needed and can we
simply drop this code again?
This issue was identified with the script ./scripts/checkkconfigsymbols.py.
Was it forgotten when handling comments to
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20200509050340.GD1464954@thinks.paulus.ozlabs.org/
?
Yes. I reported it internally to some folks but I guess they haven't had
time to send a fixup patch.
I'm pretty sure we just need the first three hunks of that patch, but it
would be good if someone with a Microwatt setup could test it.
cheers