[PATCH misc-next] drivers/misc: remove redundant rc variable

Subsystems: char and misc drivers, ocxl (open coherent accelerator processor interface opencapi) driver, the rest

STALE1681d LANDED

Landed in mainline as 30e120e6a9d2 on 2021-12-20.

3 messages, 3 authors, 2021-12-26 · open the first message on its own page

[PATCH misc-next] drivers/misc: remove redundant rc variable

From: <hidden>
Date: 2021-12-15 06:04:47

From: Minghao Chi <redacted>

Return value from ocxl_context_attach() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Minghao Chi <redacted>
---
 drivers/misc/ocxl/file.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index e70525eedaae..d881f5e40ad9 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c
@@ -74,7 +74,6 @@ static long afu_ioctl_attach(struct ocxl_context *ctx,
 {
 	struct ocxl_ioctl_attach arg;
 	u64 amr = 0;
-	int rc;
 
 	pr_debug("%s for context %d\n", __func__, ctx->pasid);
 
@@ -86,8 +85,7 @@ static long afu_ioctl_attach(struct ocxl_context *ctx,
 		return -EINVAL;
 
 	amr = arg.amr & mfspr(SPRN_UAMOR);
-	rc = ocxl_context_attach(ctx, amr, current->mm);
-	return rc;
+	return ocxl_context_attach(ctx, amr, current->mm);
 }
 
 static long afu_ioctl_get_metadata(struct ocxl_context *ctx,
-- 
2.25.1

Re: [PATCH misc-next] drivers/misc: remove redundant rc variable

From: Andrew Donnellan <hidden>
Date: 2021-12-15 08:52:44

On 15/12/21 5:04 pm, cgel.zte@gmail.com wrote:
From: Minghao Chi <redacted>

Return value from ocxl_context_attach() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Minghao Chi <redacted>
Acked-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited

Re: [PATCH misc-next] drivers/misc: remove redundant rc variable

From: Michael Ellerman <hidden>
Date: 2021-12-26 21:54:00

On Wed, 15 Dec 2021 06:04:38 +0000, cgel.zte@gmail.com wrote:
From: Minghao Chi <redacted>

Return value from ocxl_context_attach() directly instead
of taking this in another redundant variable.
Applied to powerpc/next.

[1/1] drivers/misc: remove redundant rc variable
      https://git.kernel.org/powerpc/c/30e120e6a9d247cec7effd55fd6783d5c619ed4c

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help