# \[PATCH\] powerpc/prom\_init: fix the improper check of prom\_getprop

- From: Peiwei Hu \<hidden\>
- Date: 2021-11-19 09:45:49 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/11/1579786
- Thread: https://ratatoskr.run/linuxppc-dev/2021/11/1579786/t.md

```text
prom_getprop() can return PROM_ERROR. Binary operator can not identify it.

Signed-off-by: Peiwei Hu <redacted>
---
 arch/powerpc/kernel/prom_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 18b04b08b983..f845065c860e 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -2991,7 +2991,7 @@ static void __init fixup_device_tree_efika_add_phy(void)
 
 	/* Check if the phy-handle property exists - bail if it does */
 	rv = prom_getprop(node, "phy-handle", prop, sizeof(prop));
-	if (!rv)
+	if (rv <= 0)
 		return;
 
 	/*
-- 
2.25.1

```