# \[PATCH\] powerpc: tsi108: make EXPORT\_SYMBOL follow its function immediately

- Subsystems: LINUX FOR POWERPC (32-BIT AND 64-BIT), THE REST
- Maintainers: Madhavan Srinivasan, Linus Torvalds
- Status: LANDED (a3bcfc182b2c · 2021-11-25 00:25)
- Landed in mainline as a3bcfc182b2c on 2021-11-25.
- List: linuxppc-dev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linuxppc-dev/2021/11/1571422/t

## \[PATCH\] powerpc: tsi108: make EXPORT\_SYMBOL follow its function immediately

- From: Jason Wang \<hidden\>
- Date: 2021-11-14 11:57:28 
- Message: https://ratatoskr.run/linuxppc-dev/2021/11/1571422.md

```text
EXPORT_SYMBOL(foo); should immediately follow its function/variable.

Signed-off-by: Jason Wang <redacted>
---
 arch/powerpc/sysdev/tsi108_dev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/sysdev/tsi108_dev.c b/arch/powerpc/sysdev/tsi108_dev.c
index 4c4a6efd5e5f..9e13fb35ed5c 100644
--- a/arch/powerpc/sysdev/tsi108_dev.c
+++ b/arch/powerpc/sysdev/tsi108_dev.c
@@ -51,13 +51,12 @@ phys_addr_t get_csrbase(void)
 	}
 	return tsi108_csr_base;
 }
+EXPORT_SYMBOL(get_csrbase);
 
 u32 get_vir_csrbase(void)
 {
 	return (u32) (ioremap(get_csrbase(), 0x10000));
 }
-
-EXPORT_SYMBOL(get_csrbase);
 EXPORT_SYMBOL(get_vir_csrbase);
 
 static int __init tsi108_eth_of_init(void)
-- 
2.33.0


```

## Re: \[PATCH\] powerpc: tsi108: make EXPORT\_SYMBOL follow its function immediately

- From: Michael Ellerman \<hidden\>
- Date: 2021-11-25 09:50:26 
- Message: https://ratatoskr.run/linuxppc-dev/2021/11/1586321.md

```text
On Sun, 14 Nov 2021 19:56:16 +0800, Jason Wang wrote:
> EXPORT_SYMBOL(foo); should immediately follow its function/variable.
> 
> 

Applied to powerpc/next.

[1/1] powerpc: tsi108: make EXPORT_SYMBOL follow its function immediately
      https://git.kernel.org/powerpc/c/a3bcfc182b2c968fd740101322bd128844724961

cheers
```