[PATCH] mm: Remove a repeated word in a comment

Subsystems: linux for power macintosh, the rest

STALE1755d

2 messages, 2 authors, 2021-11-15 · open the first message on its own page

[PATCH] mm: Remove a repeated word in a comment

From: Jason Wang <hidden>
Date: 2021-11-13 04:40:40

The double word `up' in a comment is repeated, thus one of
them should be removed.

Signed-off-by: Jason Wang <redacted>
---
 drivers/macintosh/mediabay.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/macintosh/mediabay.c b/drivers/macintosh/mediabay.c
index eab7e83c11c4..ec23094263e7 100644
--- a/drivers/macintosh/mediabay.c
+++ b/drivers/macintosh/mediabay.c
@@ -129,7 +129,7 @@ enum {
 /*
  * Functions for polling content of media bay
  */
- 
+
 static u8
 ohare_mb_content(struct media_bay_info *bay)
 {
@@ -331,12 +331,12 @@ static void keylargo_mb_un_reset_ide(struct media_bay_info* bay)
 
 static inline void set_mb_power(struct media_bay_info* bay, int onoff)
 {
-	/* Power up up and assert the bay reset line */
+	/* Power up and assert the bay reset line */
 	if (onoff) {
 		bay->ops->power(bay, 1);
 		bay->state = mb_powering_up;
 		pr_debug("mediabay%d: powering up\n", bay->index);
-	} else { 
+	} else {
 		/* Make sure everything is powered down & disabled */
 		bay->ops->power(bay, 0);
 		bay->state = mb_powering_down;
@@ -577,7 +577,7 @@ static int media_bay_attach(struct macio_dev *mdev,
 		macio_release_resources(mdev);
 		return -ENOMEM;
 	}
-	
+
 	i = media_bay_count++;
 	bay = &media_bays[i];
 	bay->mdev = mdev;
@@ -745,7 +745,7 @@ static int __init media_bay_init(void)
 	if (!machine_is(powermac))
 		return 0;
 
-	macio_register_driver(&media_bay_driver);	
+	macio_register_driver(&media_bay_driver);
 
 	return 0;
 }
-- 
2.33.0

Re: [PATCH] mm: Remove a repeated word in a comment

From: Christophe Leroy <hidden>
Date: 2021-11-15 08:10:47


Le 13/11/2021 à 05:40, Jason Wang a écrit :
The double word `up' in a comment is repeated, thus one of
them should be removed.
If you do other changes than this one, say it here as well, see below.
quoted hunk
Signed-off-by: Jason Wang <redacted>
---
  drivers/macintosh/mediabay.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/macintosh/mediabay.c b/drivers/macintosh/mediabay.c
index eab7e83c11c4..ec23094263e7 100644
--- a/drivers/macintosh/mediabay.c
+++ b/drivers/macintosh/mediabay.c
@@ -129,7 +129,7 @@ enum {
  /*
   * Functions for polling content of media bay
   */
-
+
This change is not part of your description.
quoted hunk
  static u8
  ohare_mb_content(struct media_bay_info *bay)
  {
@@ -331,12 +331,12 @@ static void keylargo_mb_un_reset_ide(struct media_bay_info* bay)
  
  static inline void set_mb_power(struct media_bay_info* bay, int onoff)
  {
-	/* Power up up and assert the bay reset line */
+	/* Power up and assert the bay reset line */
  	if (onoff) {
  		bay->ops->power(bay, 1);
  		bay->state = mb_powering_up;
  		pr_debug("mediabay%d: powering up\n", bay->index);
-	} else {
+	} else {
This change is not part of your description.
quoted hunk
  		/* Make sure everything is powered down & disabled */
  		bay->ops->power(bay, 0);
  		bay->state = mb_powering_down;
@@ -577,7 +577,7 @@ static int media_bay_attach(struct macio_dev *mdev,
  		macio_release_resources(mdev);
  		return -ENOMEM;
  	}
-	
+
This change is not part of your description.
quoted hunk
  	i = media_bay_count++;
  	bay = &media_bays[i];
  	bay->mdev = mdev;
@@ -745,7 +745,7 @@ static int __init media_bay_init(void)
  	if (!machine_is(powermac))
  		return 0;
  
-	macio_register_driver(&media_bay_driver);	
+	macio_register_driver(&media_bay_driver);
This change is not part of your description.
  
  	return 0;
  }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help