[PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1763d

2 messages, 1 author, 2021-11-09 · open the first message on its own page

[PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe

From: He Ying <hidden>
Date: 2021-11-03 01:46:56

Early exits from for_each_compatible_node() should decrease the
node reference count.

Signed-off-by: He Ying <redacted>
---
 arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
index 15396333a90b..a4b020e4b6af 100644
--- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
+++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
@@ -214,6 +214,7 @@ void hlwd_pic_probe(void)
 			irq_set_chained_handler(cascade_virq,
 						hlwd_pic_irq_cascade);
 			hlwd_irq_host = host;
+			of_node_put(np);
 			break;
 		}
 	}
-- 
2.17.1

Re: [PATCH] powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe

From: He Ying <hidden>
Date: 2021-11-09 02:07:48

kindly ping...

在 2021/11/3 9:48, He Ying 写道:
quoted hunk
Early exits from for_each_compatible_node() should decrease the
node reference count.

Signed-off-by: He Ying <redacted>
---
  arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
index 15396333a90b..a4b020e4b6af 100644
--- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
+++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
@@ -214,6 +214,7 @@ void hlwd_pic_probe(void)
  			irq_set_chained_handler(cascade_virq,
  						hlwd_pic_irq_cascade);
  			hlwd_irq_host = host;
+			of_node_put(np);
  			break;
  		}
  	}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help