# Re: \[PATCH 06/13\] nvdimm/blk: avoid calling del\_gendisk() on early failures

- From: Luis Chamberlain \<mcgrof@kernel.org\>
- Date: 2021-11-03 00:11:09 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/11/1561357
- Thread: https://ratatoskr.run/linux-block/2021/10/1543973/t.md

```text
On Fri, Oct 15, 2021 at 05:13:48PM -0700, Dan Williams wrote:
> On Fri, Oct 15, 2021 at 4:53 PM Luis Chamberlain [ref] wrote:
> >
> > If nd_integrity_init() fails we'd get del_gendisk() called,
> > but that's not correct as we should only call that if we're
> > done with device_add_disk(). Fix this by providing unwinding
> > prior to the devm call being registered and moving the devm
> > registration to the very end.
> >
> > This should fix calling del_gendisk() if nd_integrity_init()
> > fails. I only spotted this issue through code inspection. It
> > does not fix any real world bug.
> >
> 
> Just fyi, I'm preparing patches to delete this driver completely as it
> is unused by any shipping platform. I hope to get that removal into
> v5.16.

Curious if are you going to nuking it on v5.16? Otherwise it would stand
in the way of the last few patches to add __must_check for the final
add_disk() error handling changes.

  Luis
```