[PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/soc/fsl/dpaa2-fd.h    | 3 ++-
 include/soc/fsl/qe/immap_qe.h | 3 ++-
 include/soc/fsl/qe/qe_tdm.h   | 4 +++-
 include/soc/fsl/qe/ucc_fast.h | 2 +-
 include/soc/fsl/qe/ucc_slow.h | 2 +-
 5 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/include/soc/fsl/dpaa2-fd.h b/include/soc/fsl/dpaa2-fd.h
index 90ae8d191f1a..bae490cac0aa 100644
--- a/include/soc/fsl/dpaa2-fd.h
+++ b/include/soc/fsl/dpaa2-fd.h

@@ -7,7 +7,8 @@
 #ifndef __FSL_DPAA2_FD_H
 #define __FSL_DPAA2_FD_H
 
-#include <linux/kernel.h>
+#include <linux/byteorder/generic.h>
+#include <linux/types.h>
 
 /**
  * DOC: DPAA2 FD - Frame Descriptor APIs for DPAA2

diff --git a/include/soc/fsl/qe/immap_qe.h b/include/soc/fsl/qe/immap_qe.h
index 7614fee532f1..edd601f53f5d 100644
--- a/include/soc/fsl/qe/immap_qe.h
+++ b/include/soc/fsl/qe/immap_qe.h

@@ -13,7 +13,8 @@
 #define _ASM_POWERPC_IMMAP_QE_H
 #ifdef __KERNEL__
 
-#include <linux/kernel.h>
+#include <linux/types.h>
+
 #include <asm/io.h>
 
 #define QE_IMMAP_SIZE	(1024 * 1024)	/* 1MB from 1MB+IMMR */

diff --git a/include/soc/fsl/qe/qe_tdm.h b/include/soc/fsl/qe/qe_tdm.h
index b6febe225071..43ea830cfe1f 100644
--- a/include/soc/fsl/qe/qe_tdm.h
+++ b/include/soc/fsl/qe/qe_tdm.h

@@ -10,8 +10,8 @@
 #ifndef _QE_TDM_H_
 #define _QE_TDM_H_
 
-#include <linux/kernel.h>
 #include <linux/list.h>
+#include <linux/types.h>
 
 #include <soc/fsl/qe/immap_qe.h>
 #include <soc/fsl/qe/qe.h>

@@ -19,6 +19,8 @@
 #include <soc/fsl/qe/ucc.h>
 #include <soc/fsl/qe/ucc_fast.h>
 
+struct device_node;
+
 /* SI RAM entries */
 #define SIR_LAST	0x0001
 #define SIR_BYTE	0x0002

diff --git a/include/soc/fsl/qe/ucc_fast.h b/include/soc/fsl/qe/ucc_fast.h
index 9696a5b9b5d1..ad60b87a3c69 100644
--- a/include/soc/fsl/qe/ucc_fast.h
+++ b/include/soc/fsl/qe/ucc_fast.h

@@ -10,7 +10,7 @@
 #ifndef __UCC_FAST_H__
 #define __UCC_FAST_H__
 
-#include <linux/kernel.h>
+#include <linux/types.h>
 
 #include <soc/fsl/qe/immap_qe.h>
 #include <soc/fsl/qe/qe.h>

diff --git a/include/soc/fsl/qe/ucc_slow.h b/include/soc/fsl/qe/ucc_slow.h
index 11a216e4e919..7548ce8a202d 100644
--- a/include/soc/fsl/qe/ucc_slow.h
+++ b/include/soc/fsl/qe/ucc_slow.h

@@ -11,7 +11,7 @@
 #ifndef __UCC_SLOW_H__
 #define __UCC_SLOW_H__
 
-#include <linux/kernel.h>
+#include <linux/types.h>
 
 #include <soc/fsl/qe/immap_qe.h>
 #include <soc/fsl/qe/qe.h>

-- 
2.33.0

On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote:

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Seems nobody from PPC took this patch.
Any idea who can take it?

-- 
With Best Regards,
Andy Shevchenko

Le 29/10/2021 à 17:55, Andy Shevchenko a écrit :

On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote:

quoted

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Seems nobody from PPC took this patch.
Any idea who can take it?

You have to check in MAINTAINERS file in the root directory of kernel 
sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS

That's Michael who takes them. But you have to allow him enough time for it.

Christophe

Le 29/10/2021 à 17:55, Andy Shevchenko a écrit :

On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote:

quoted

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Seems nobody from PPC took this patch.
Any idea who can take it?

You have to check in MAINTAINERS file in the root directory of kernel 
sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS

That's Michael who takes them. But you have to allow him enough time for it.

Christophe

On Fri, Oct 29, 2021 at 10:04 PM LEROY Christophe
[off-list ref] wrote:

Le 29/10/2021 à 17:55, Andy Shevchenko a écrit :

quoted

On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote:

quoted

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Seems nobody from PPC took this patch.
Any idea who can take it?

You have to check in MAINTAINERS file in the root directory of kernel
sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS

Actually for these files get_maintainer.pl showed nothing.
I have chosen PPC maintainers manually.

That's Michael who takes them. But you have to allow him enough time for it.

Thanks!

I wrote that message because I have got a notification from checkpatch
that it should go somewhere else.

-- 
With Best Regards,
Andy Shevchenko

Le 29/10/2021 à 22:31, Andy Shevchenko a écrit :

On Fri, Oct 29, 2021 at 10:04 PM LEROY Christophe
[off-list ref] wrote:

quoted

Le 29/10/2021 à 17:55, Andy Shevchenko a écrit :

quoted

On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote:

quoted

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Seems nobody from PPC took this patch.
Any idea who can take it?

You have to check in MAINTAINERS file in the root directory of kernel
sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS

Actually for these files get_maintainer.pl showed nothing.
I have chosen PPC maintainers manually.

quoted

That's Michael who takes them. But you have to allow him enough time for it.

Thanks!

I wrote that message because I have got a notification from checkpatch
that it should go somewhere else.

That means that Michael considered it is not for him.

And I think the reason is that in MAINTAINERS you have:

FREESCALE QUICC ENGINE LIBRARY
M:	Qiang Zhao [off-list ref]
L:	linuxppc-dev@lists.ozlabs.org
S:	Maintained
F:	drivers/soc/fsl/qe/
F:	include/soc/fsl/*qe*.h
F:	include/soc/fsl/*ucc*.h


FREESCALE SOC DRIVERS
M:	Li Yang [off-list ref]
L:	linuxppc-dev@lists.ozlabs.org
L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
S:	Maintained
F:	Documentation/devicetree/bindings/misc/fsl,dpaa2-console.yaml
F:	Documentation/devicetree/bindings/soc/fsl/
F:	drivers/soc/fsl/
F:	include/linux/fsl/

Sorry I overlooked your patch.

Christophe

On Saturday, October 30, 2021, Christophe Leroy [off-list ref]
wrote:

Le 29/10/2021 à 22:31, Andy Shevchenko a écrit :

quoted

On Fri, Oct 29, 2021 at 10:04 PM LEROY Christophe
[off-list ref] wrote:

quoted

Le 29/10/2021 à 17:55, Andy Shevchenko a écrit :

quoted

On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote:

quoted

When kernel.h is used in the headers it adds a lot into dependency
hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Seems nobody from PPC took this patch.
Any idea who can take it?

You have to check in MAINTAINERS file in the root directory of kernel
sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS

Actually for these files get_maintainer.pl showed nothing.
I have chosen PPC maintainers manually.

That's Michael who takes them. But you have to allow him enough time for

quoted

it.

Thanks!

I wrote that message because I have got a notification from checkpatch
that it should go somewhere else.

That means that Michael considered it is not for him.

And I think the reason is that in MAINTAINERS you have:

FREESCALE QUICC ENGINE LIBRARY
M:      Qiang Zhao [off-list ref]
L:      linuxppc-dev@lists.ozlabs.org
S:      Maintained
F:      drivers/soc/fsl/qe/
F:      include/soc/fsl/*qe*.h
F:      include/soc/fsl/*ucc*.h


FREESCALE SOC DRIVERS
M:      Li Yang [off-list ref]
L:      linuxppc-dev@lists.ozlabs.org
L:      linux-arm-kernel@lists.infradead.org (moderated for
non-subscribers)
S:      Maintained
F:      Documentation/devicetree/bindings/misc/fsl,dpaa2-console.yaml
F:      Documentation/devicetree/bindings/soc/fsl/
F:      drivers/soc/fsl/
F:      include/linux/fsl/

Thanks! Now I should understand why get_maintainer hadn’t showed above for
me.

Sorry I overlooked your patch.

NP

Christophe

-- 
With Best Regards,
Andy Shevchenko

On Sat, Oct 30, 2021 at 10:28:01AM +0300, Andy Shevchenko wrote:

On Saturday, October 30, 2021, Christophe Leroy [off-list ref]
wrote:

quoted

Le 29/10/2021 à 22:31, Andy Shevchenko a écrit :

...

quoted

That means that Michael considered it is not for him.

And I think the reason is that in MAINTAINERS you have:

FREESCALE QUICC ENGINE LIBRARY
M:      Qiang Zhao [off-list ref]
L:      linuxppc-dev@lists.ozlabs.org
S:      Maintained
F:      drivers/soc/fsl/qe/
F:      include/soc/fsl/*qe*.h
F:      include/soc/fsl/*ucc*.h


FREESCALE SOC DRIVERS
M:      Li Yang [off-list ref]
L:      linuxppc-dev@lists.ozlabs.org
L:      linux-arm-kernel@lists.infradead.org (moderated for
non-subscribers)
S:      Maintained
F:      Documentation/devicetree/bindings/misc/fsl,dpaa2-console.yaml
F:      Documentation/devicetree/bindings/soc/fsl/
F:      drivers/soc/fsl/
F:      include/linux/fsl/

Thanks! Now I should understand why get_maintainer hadn’t showed above for
me.

He-he, there are two bugs in MAINTAINERS.
v2 has been sent with the corresponding fixes and updated Cc list.

-- 
With Best Regards,
Andy Shevchenko