# \[PATCH\] powerpc/code-patching: Return error on patch\_branch() out-of-range failure - Subsystems: LINUX FOR POWERPC (32-BIT AND 64-BIT), THE REST - Maintainers: Madhavan Srinivasan, Linus Torvalds - List: linuxppc-dev - 2 messages, 2 authors - Page: https://ratatoskr.run/linuxppc-dev/2021/09/1496566/t ## \[PATCH\] powerpc/code-patching: Return error on patch\_branch() out-of-range failure - From: Christophe Leroy \ - Date: 2021-09-03 08:23:20 - Message: https://ratatoskr.run/linuxppc-dev/2021/09/1496566.md ```text Do not silentely ignore a failure of create_branch() in patch_branch(). Return -ERANGE. Signed-off-by: Christophe Leroy --- arch/powerpc/lib/code-patching.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/lib/code-patching.c b/arch/powerpc/lib/code-patching.c index f9a3019e37b4..0bc9cc0416b8 100644 --- a/arch/powerpc/lib/code-patching.c +++ b/arch/powerpc/lib/code-patching.c @@ -202,7 +202,9 @@ int patch_branch(u32 *addr, unsigned long target, int flags) { struct ppc_inst instr; - create_branch(&instr, addr, target, flags); + if (create_branch(&instr, addr, target, flags)) + return -ERANGE; + return patch_instruction(addr, instr); } -- 2.25.0 ``` ## Re: \[PATCH\] powerpc/code-patching: Return error on patch\_branch() out-of-range failure - From: Naveen N. Rao \ - Date: 2021-09-22 12:18:26 - Message: https://ratatoskr.run/linuxppc-dev/2021/09/1518222.md ```text Christophe Leroy wrote: > Do not silentely ignore a failure of create_branch() in > patch_branch(). Return -ERANGE. > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/lib/code-patching.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Naveen N. Rao > > diff --git a/arch/powerpc/lib/code-patching.c b/arch/powerpc/lib/code-patching.c > index f9a3019e37b4..0bc9cc0416b8 100644 > --- a/arch/powerpc/lib/code-patching.c > +++ b/arch/powerpc/lib/code-patching.c > @@ -202,7 +202,9 @@ int patch_branch(u32 *addr, unsigned long target, int flags) > { > struct ppc_inst instr; > > - create_branch(&instr, addr, target, flags); > + if (create_branch(&instr, addr, target, flags)) > + return -ERANGE; > + > return patch_instruction(addr, instr); > } > > -- > 2.25.0 > > ```