[PATCH linux-next] selftests/powerpc: remove duplicate include

Subsystems: kernel selftest framework, the rest

STALE1816d

4 messages, 3 authors, 2021-08-24 · open the first message on its own page

[PATCH linux-next] selftests/powerpc: remove duplicate include

From: CGEL <hidden>
Date: 2021-08-24 03:10:32

From: Changcheng Deng <redacted>

Clean up the following includecheck warning:

./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
more than once.

No functional change.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Changcheng Deng <redacted>
---
 tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26..27c083a 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
 #include <sched.h>
 #include <sys/types.h>
 #include <signal.h>
-#include <inttypes.h>
 
 #include "tm.h"
 
-- 
1.8.3.1

Re: [PATCH linux-next] selftests/powerpc: remove duplicate include

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2021-08-24 14:41:53

On 8/23/21 9:05 PM, CGEL wrote:
quoted hunk
From: Changcheng Deng <redacted>

Clean up the following includecheck warning:

./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
more than once.

No functional change.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Changcheng Deng <redacted>
---
  tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26..27c083a 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
  #include <sched.h>
  #include <sys/types.h>
  #include <signal.h>
-#include <inttypes.h>
  
  #include "tm.h"
  
We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah

Re: [PATCH linux-next] selftests/powerpc: remove duplicate include

From: Christophe Leroy <hidden>
Date: 2021-08-24 16:35:24


Le 24/08/2021 à 16:41, Shuah Khan a écrit :
On 8/23/21 9:05 PM, CGEL wrote:
quoted
From: Changcheng Deng <redacted>

Clean up the following includecheck warning:

./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
more than once.

No functional change.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Changcheng Deng <redacted>
---
  tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c 
b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26..27c083a 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
  #include <sched.h>
  #include <sys/types.h>
  #include <signal.h>
-#include <inttypes.h>
  #include "tm.h"
We can't accept this patch. The from and Signed-off-by don't match.
As far as I can see they match:

From: Changcheng Deng <redacted>
Signed-off-by: Changcheng Deng <redacted>

Christophe

Re: [PATCH linux-next] selftests/powerpc: remove duplicate include

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2021-08-24 16:42:28

On 8/24/21 10:35 AM, Christophe Leroy wrote:

Le 24/08/2021 à 16:41, Shuah Khan a écrit :
quoted
On 8/23/21 9:05 PM, CGEL wrote:
quoted
From: Changcheng Deng <redacted>

Clean up the following includecheck warning:

./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
more than once.

No functional change.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Changcheng Deng <redacted>
---
  tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26..27c083a 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
  #include <sched.h>
  #include <sys/types.h>
  #include <signal.h>
-#include <inttypes.h>
  #include "tm.h"
We can't accept this patch. The from and Signed-off-by don't match.
As far as I can see they match:

From: Changcheng Deng <redacted>
Signed-off-by: Changcheng Deng <redacted>
Yeah. My bad.

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help