[PATCH] powerpc/tau: Add 'static' storage qualifier to 'tau_work' definition

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1811d LANDED

Landed in mainline as 6cd717fe9b3a on 2021-08-20.

2 messages, 2 authors, 2021-08-27 · open the first message on its own page

[PATCH] powerpc/tau: Add 'static' storage qualifier to 'tau_work' definition

From: Finn Thain <fthain@linux-m68k.org>
Date: 2021-08-19 00:47:54

This patch prevents the following sparse warning.

arch/powerpc/kernel/tau_6xx.c:199:1: sparse: sparse: symbol 'tau_work'
was not declared. Should it be static?

Reported-by: kernel test robot <redacted>
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
---
 arch/powerpc/kernel/tau_6xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c
index b9a047d92ec0..8e83d19fe8fa 100644
--- a/arch/powerpc/kernel/tau_6xx.c
+++ b/arch/powerpc/kernel/tau_6xx.c
@@ -164,7 +164,7 @@ static void tau_work_func(struct work_struct *work)
 	queue_work(tau_workq, work);
 }
 
-DECLARE_WORK(tau_work, tau_work_func);
+static DECLARE_WORK(tau_work, tau_work_func);
 
 /*
  * setup the TAU
-- 
2.26.3

Re: [PATCH] powerpc/tau: Add 'static' storage qualifier to 'tau_work' definition

From: Michael Ellerman <hidden>
Date: 2021-08-27 13:22:57

On Thu, 19 Aug 2021 10:46:54 +1000, Finn Thain wrote:
This patch prevents the following sparse warning.

arch/powerpc/kernel/tau_6xx.c:199:1: sparse: sparse: symbol 'tau_work'
was not declared. Should it be static?



[...]
Applied to powerpc/next.

[1/1] powerpc/tau: Add 'static' storage qualifier to 'tau_work' definition
      https://git.kernel.org/powerpc/c/6cd717fe9b3a787f8e8f9d0bc9b7634a9c104b3e

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help