[PATCH linux-next] module: remove duplicate include in interrupt.c

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1844d

2 messages, 2 authors, 2021-08-16 · open the first message on its own page

[PATCH linux-next] module: remove duplicate include in interrupt.c

From: <hidden>
Date: 2021-08-16 11:35:13

From: Lv Ruyi <redacted>

'asm/interrupt.h' included in 'interrupt.c' is duplicated.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Lv Ruyi <redacted>
---
 arch/powerpc/kernel/interrupt.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
index 21bbd615ca41..8a936515e4e4 100644
--- a/arch/powerpc/kernel/interrupt.c
+++ b/arch/powerpc/kernel/interrupt.c
@@ -10,7 +10,6 @@
 #include <asm/cputime.h>
 #include <asm/interrupt.h>
 #include <asm/hw_irq.h>
-#include <asm/interrupt.h>
 #include <asm/kprobes.h>
 #include <asm/paca.h>
 #include <asm/ptrace.h>
-- 
2.25.1

Re: [PATCH linux-next] module: remove duplicate include in interrupt.c

From: Christophe Leroy <hidden>
Date: 2021-08-16 11:57:43


Le 16/08/2021 à 13:34, cgel.zte@gmail.com a écrit :
From: Lv Ruyi <redacted>

'asm/interrupt.h' included in 'interrupt.c' is duplicated.
This patch has been submitted at least half a dozen of times already.

You should maintain alphabetic order in the include list.

But please don't post it again, we have it in the pipe already, see 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1624329437-84730-1-git-send-email-jiapeng.chong@linux.alibaba.com/

Next time please check at https://patchwork.ozlabs.org/project/linuxppc-dev/list/ before submitting 
a new patch.

Thanks
Christophe
quoted hunk
Reported-by: Zeal Robot <redacted>
Signed-off-by: Lv Ruyi <redacted>
---
  arch/powerpc/kernel/interrupt.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
index 21bbd615ca41..8a936515e4e4 100644
--- a/arch/powerpc/kernel/interrupt.c
+++ b/arch/powerpc/kernel/interrupt.c
@@ -10,7 +10,6 @@
  #include <asm/cputime.h>
  #include <asm/interrupt.h>
  #include <asm/hw_irq.h>
-#include <asm/interrupt.h>
  #include <asm/kprobes.h>
  #include <asm/paca.h>
  #include <asm/ptrace.h>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help