# Re: \[PATCH v2\] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)

- From: Thomas Bogendoerfer \<tsbogend@alpha.franken.de\>
- Date: 2021-08-05 09:17:35 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/08/1468565
- Thread: https://ratatoskr.run/linux-mips/2021/07/1463924/t.md

```text
On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
> 
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
> 
> Remove all the meaningless conditionals.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
> Changes in v2:
>   - Fix csky as well
> 
>  [..]
>  arch/mips/vdso/Makefile             |  2 --

Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
```