[PATCH linux-next] powerpc/tm: remove duplicate include in tm-poison.c

Subsystems: kernel selftest framework, the rest

STALE1811d

4 messages, 4 authors, 2021-08-26 · open the first message on its own page

[PATCH linux-next] powerpc/tm: remove duplicate include in tm-poison.c

From: <hidden>
Date: 2021-08-05 06:52:23

From: yong yiran <redacted>

'inttypes.h' included in 'tm-poison.c' is duplicated.
Remove all but the first include of inttypes.h from tm-poison.c.

Reported-by: Zeal Robot <redacted>
Signed-off-by: yong yiran <redacted>
---
 tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26af7b9..27c083a03d1f 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
 #include <sched.h>
 #include <sys/types.h>
 #include <signal.h>
-#include <inttypes.h>
 
 #include "tm.h"
 
-- 
2.25.1

Re: [PATCH linux-next] powerpc/tm: remove duplicate include in tm-poison.c

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2021-08-24 14:40:26

On 8/5/21 12:52 AM, cgel.zte@gmail.com wrote:
quoted hunk
From: yong yiran <redacted>

'inttypes.h' included in 'tm-poison.c' is duplicated.
Remove all but the first include of inttypes.h from tm-poison.c.

Reported-by: Zeal Robot <redacted>
Signed-off-by: yong yiran <redacted>
---
  tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26af7b9..27c083a03d1f 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
  #include <sched.h>
  #include <sys/types.h>
  #include <signal.h>
-#include <inttypes.h>
  
  #include "tm.h"
  
We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah

Re: [PATCH linux-next] powerpc/tm: remove duplicate include in tm-poison.c

From: Christophe Leroy <hidden>
Date: 2021-08-24 16:34:34


Le 24/08/2021 à 16:40, Shuah Khan a écrit :
On 8/5/21 12:52 AM, cgel.zte@gmail.com wrote:
quoted
From: yong yiran <redacted>

'inttypes.h' included in 'tm-poison.c' is duplicated.
Remove all but the first include of inttypes.h from tm-poison.c.

Reported-by: Zeal Robot <redacted>
Signed-off-by: yong yiran <redacted>
---
  tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c 
b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26af7b9..27c083a03d1f 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
  #include <sched.h>
  #include <sys/types.h>
  #include <signal.h>
-#include <inttypes.h>
  #include "tm.h"
We can't accept this patch. The from and Signed-off-by don't match.
As far as I can see they match. You have:

From: yong yiran <redacted>
Signed-off-by: yong yiran <redacted>

Re: [PATCH linux-next] powerpc/tm: remove duplicate include in tm-poison.c

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2021-08-26 14:26:44

Christophe Leroy [off-list ref] writes:
Le 24/08/2021 à 16:40, Shuah Khan a écrit :
quoted
On 8/5/21 12:52 AM, cgel.zte@gmail.com wrote:
quoted
From: yong yiran <redacted>

'inttypes.h' included in 'tm-poison.c' is duplicated.
Remove all but the first include of inttypes.h from tm-poison.c.

Reported-by: Zeal Robot <redacted>
Signed-off-by: yong yiran <redacted>
---
  tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c 
b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26af7b9..27c083a03d1f 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
  #include <sched.h>
  #include <sys/types.h>
  #include <signal.h>
-#include <inttypes.h>
  #include "tm.h"
We can't accept this patch. The from and Signed-off-by don't match.
As far as I can see they match. You have:

From: yong yiran <redacted>
Signed-off-by: yong yiran <redacted>
Regardless I already have a patch queued to fix this, from a different
CI bot.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help