[PATCH] powerpc/64s: accumulate_stolen_time remove irq mask workaround

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1935d LANDED

Landed in mainline as 0cdff98b395e on 2021-06-24.

2 messages, 2 authors, 2021-06-25 · open the first message on its own page

[PATCH] powerpc/64s: accumulate_stolen_time remove irq mask workaround

From: Nicholas Piggin <npiggin@gmail.com>
Date: 2021-06-23 02:30:04

The caller has been moved to C after irq soft-mask state has been
reconciled, and Linux irqs have been marked as disabled, so this
does not have to play games with irq internals.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/kernel/time.c | 11 -----------
 1 file changed, 11 deletions(-)
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index b67d93a609a2..d0308e804063 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -231,24 +231,13 @@ static u64 scan_dispatch_log(u64 stop_tb)
 void notrace accumulate_stolen_time(void)
 {
 	u64 sst, ust;
-	unsigned long save_irq_soft_mask = irq_soft_mask_return();
 	struct cpu_accounting_data *acct = &local_paca->accounting;
 
-	/* We are called early in the exception entry, before
-	 * soft/hard_enabled are sync'ed to the expected state
-	 * for the exception. We are hard disabled but the PACA
-	 * needs to reflect that so various debug stuff doesn't
-	 * complain
-	 */
-	irq_soft_mask_set(IRQS_DISABLED);
-
 	sst = scan_dispatch_log(acct->starttime_user);
 	ust = scan_dispatch_log(acct->starttime);
 	acct->stime -= sst;
 	acct->utime -= ust;
 	acct->steal_time += ust + sst;
-
-	irq_soft_mask_set(save_irq_soft_mask);
 }
 
 static inline u64 calculate_stolen_time(u64 stop_tb)
-- 
2.23.0

Re: [PATCH] powerpc/64s: accumulate_stolen_time remove irq mask workaround

From: Michael Ellerman <hidden>
Date: 2021-06-25 06:26:31

On Wed, 23 Jun 2021 12:29:24 +1000, Nicholas Piggin wrote:
The caller has been moved to C after irq soft-mask state has been
reconciled, and Linux irqs have been marked as disabled, so this
does not have to play games with irq internals.
Applied to powerpc/next.

[1/1] powerpc/64s: accumulate_stolen_time remove irq mask workaround
      https://git.kernel.org/powerpc/c/0cdff98b395e5ab71b650c3df154217b1348e9b5

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help