[PATCH 1/1] ALSA: aoa: remove unnecessary oom message

Subsystems: aoa (apple onboard audio) alsa driver, sound, the rest

STALE1951d LANDED

Landed in mainline as 37d122c5768b on 2021-06-17.

2 messages, 2 authors, 2021-06-17 · open the first message on its own page

[PATCH 1/1] ALSA: aoa: remove unnecessary oom message

From: Zhen Lei <hidden>
Date: 2021-06-17 10:28:23

Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <redacted>
---
 sound/aoa/soundbus/i2sbus/pcm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/aoa/soundbus/i2sbus/pcm.c b/sound/aoa/soundbus/i2sbus/pcm.c
index 1c8e8131a716..a9e502a6cdeb 100644
--- a/sound/aoa/soundbus/i2sbus/pcm.c
+++ b/sound/aoa/soundbus/i2sbus/pcm.c
@@ -918,10 +918,8 @@ i2sbus_attach_codec(struct soundbus_dev *dev, struct snd_card *card,
 	}
 
 	cii = kzalloc(sizeof(struct codec_info_item), GFP_KERNEL);
-	if (!cii) {
-		printk(KERN_DEBUG "i2sbus: failed to allocate cii\n");
+	if (!cii)
 		return -ENOMEM;
-	}
 
 	/* use the private data to point to the codec info */
 	cii->sdev = soundbus_dev_get(dev);
-- 
2.25.1

Re: [PATCH 1/1] ALSA: aoa: remove unnecessary oom message

From: Takashi Iwai <hidden>
Date: 2021-06-17 15:48:09

On Thu, 17 Jun 2021 12:27:45 +0200,
Zhen Lei wrote:
Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <redacted>
Thanks, applied.


Takashi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help