# Re: \[PATCH 14/26\] md: convert to blk\_alloc\_disk/blk\_cleanup\_disk

- From: Hannes Reinecke \<hare@suse.de\>
- Date: 2021-05-24 08:27:21 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/05/6402909
- Thread: https://ratatoskr.run/linux-block/2021/05/6402806/t.md

```text
On 5/24/21 9:26 AM, Christoph Hellwig wrote:
> On Sun, May 23, 2021 at 10:12:49AM +0200, Hannes Reinecke wrote:
>>> +	blk_set_stacking_limits(&mddev->queue->limits);
>>>    	blk_queue_write_cache(mddev->queue, true, true);
>>>    	/* Allow extended partitions.  This makes the
>>>    	 * 'mdp' device redundant, but we can't really
>>>
>> Wouldn't it make sense to introduce a helper 'blk_queue_from_disk()' or
>> somesuch to avoid having to keep an explicit 'queue' pointer?
>
> My rought plan is that a few series from now bio based drivers will
> never directly deal with the request_queue at all.
>
Go for it.

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
```