[PATCH] powerpc/32s: Speed up likely path of kuap_update_sr()

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1913d LANDED

Landed in mainline as 8af8d72dc58e on 2021-05-17.

2 messages, 2 authors, 2021-06-06 · open the first message on its own page

[PATCH] powerpc/32s: Speed up likely path of kuap_update_sr()

From: Christophe Leroy <hidden>
Date: 2021-05-06 13:27:38

In most cases, kuap_update_sr() will update a single segment
register.

We know that first update will always be done, if there is no
segment register to update at all, kuap_update_sr() is not
called.

Avoid recurring calculations and tests in that case.

Signed-off-by: Christophe Leroy <redacted>
---
 arch/powerpc/include/asm/book3s/32/kup.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/include/asm/book3s/32/kup.h b/arch/powerpc/include/asm/book3s/32/kup.h
index 1670dfe9d4f1..c1f7c2e625a6 100644
--- a/arch/powerpc/include/asm/book3s/32/kup.h
+++ b/arch/powerpc/include/asm/book3s/32/kup.h
@@ -15,11 +15,13 @@ static inline void kuap_update_sr(u32 sr, u32 addr, u32 end)
 {
 	addr &= 0xf0000000;	/* align addr to start of segment */
 	barrier();	/* make sure thread.kuap is updated before playing with SRs */
-	while (addr < end) {
+	for (;;) {
 		mtsr(sr, addr);
+		addr += 0x10000000;	/* address of next segment */
+		if (addr >= end)
+			break;
 		sr += 0x111;		/* next VSID */
 		sr &= 0xf0ffffff;	/* clear VSID overflow */
-		addr += 0x10000000;	/* address of next segment */
 	}
 	isync();	/* Context sync required after mtsr() */
 }
-- 
2.25.0

Re: [PATCH] powerpc/32s: Speed up likely path of kuap_update_sr()

From: Michael Ellerman <hidden>
Date: 2021-06-06 12:12:15

On Thu, 6 May 2021 13:27:31 +0000 (UTC), Christophe Leroy wrote:
In most cases, kuap_update_sr() will update a single segment
register.

We know that first update will always be done, if there is no
segment register to update at all, kuap_update_sr() is not
called.

[...]
Applied to powerpc/next.

[1/1] powerpc/32s: Speed up likely path of kuap_update_sr()
      https://git.kernel.org/powerpc/c/8af8d72dc58e90dc945ca627b24968400e0f21b6

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help