# \[PATCH\] Documentation PCI: Fix typo in pci-error-recovery.rst

- Subsystems: PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC, DOCUMENTATION, PCI ERROR RECOVERY, PCI SUBSYSTEM, THE REST
- Maintainers: Mahesh J Salgaonkar, Jonathan Corbet, Linas Vepstas, Bjorn Helgaas, Linus Torvalds
- Status: LANDED (8e3237989b0d · 2021-06-01 16:01)
- Landed in mainline as 8e3237989b0d on 2021-06-01.
- List: linuxppc-dev
- 4 messages, 4 authors
- Page: https://ratatoskr.run/linuxppc-dev/2021/05/1396292/t

## \[PATCH\] Documentation PCI: Fix typo in pci-error-recovery.rst

- From: Wesley Sheng \<hidden\>
- Date: 2021-05-31 08:12:42 
- Message: https://ratatoskr.run/linuxppc-dev/2021/05/1396292.md

```text
Replace "It" with "If", since it is a conditional statement.

Signed-off-by: Wesley Sheng <redacted>
---
 Documentation/PCI/pci-error-recovery.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/PCI/pci-error-recovery.rst b/Documentation/PCI/pci-error-recovery.rst
index 84ceebb08cac..187f43a03200 100644
--- a/Documentation/PCI/pci-error-recovery.rst
+++ b/Documentation/PCI/pci-error-recovery.rst
@@ -295,7 +295,7 @@ and let the driver restart normal I/O processing.
 A driver can still return a critical failure for this function if
 it can't get the device operational after reset.  If the platform
 previously tried a soft reset, it might now try a hard reset (power
-cycle) and then call slot_reset() again.  It the device still can't
+cycle) and then call slot_reset() again.  If the device still can't
 be recovered, there is nothing more that can be done;  the platform
 will typically report a "permanent failure" in such a case.  The
 device will be considered "dead" in this case.
-- 
2.25.1

```

## Re: \[PATCH\] Documentation PCI: Fix typo in pci-error-recovery.rst

- From: Linas Vepstas \<linasvepstas@gmail.com\>
- Date: 2021-05-31 12:29:12 
- Message: https://ratatoskr.run/linuxppc-dev/2021/05/9522944.md

```text
Signed-off-by: Linas Vepstas <linasvepstas@gmail.com>

On Mon, May 31, 2021 at 3:12 AM Wesley Sheng [ref] wrote:

> Replace "It" with "If", since it is a conditional statement.
>
> Signed-off-by: Wesley Sheng <redacted>
> ---
>  Documentation/PCI/pci-error-recovery.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/PCI/pci-error-recovery.rst
> b/Documentation/PCI/pci-error-recovery.rst
> index 84ceebb08cac..187f43a03200 100644
> --- a/Documentation/PCI/pci-error-recovery.rst
> +++ b/Documentation/PCI/pci-error-recovery.rst
> @@ -295,7 +295,7 @@ and let the driver restart normal I/O processing.
>  A driver can still return a critical failure for this function if
>  it can't get the device operational after reset.  If the platform
>  previously tried a soft reset, it might now try a hard reset (power
> -cycle) and then call slot_reset() again.  It the device still can't
> +cycle) and then call slot_reset() again.  If the device still can't
>  be recovered, there is nothing more that can be done;  the platform
>  will typically report a "permanent failure" in such a case.  The
>  device will be considered "dead" in this case.
> --
> 2.25.1
>
>

-- 
Patrick: Are they laughing at us?
Sponge Bob: No, Patrick, they are laughing next to us.
```

## Re: \[PATCH\] Documentation PCI: Fix typo in pci-error-recovery.rst

- From: Krzysztof Wilczyński \<hidden\>
- Date: 2021-05-31 16:03:14 
- Message: https://ratatoskr.run/linuxppc-dev/2021/05/1397429.md

```text
Hi Wesley,

> Replace "It" with "If", since it is a conditional statement.
> 
[...]

Nice catch!

> -cycle) and then call slot_reset() again.  It the device still can't
> +cycle) and then call slot_reset() again.  If the device still can't
[...]

Thank you!

Reviewed-by: Krzysztof Wilczyński <redacted>

	Krzysztof
```

## Re: \[PATCH\] Documentation PCI: Fix typo in pci-error-recovery.rst

- From: Bjorn Helgaas \<helgaas@kernel.org\>
- Date: 2021-06-01 16:11:37 
- Message: https://ratatoskr.run/linuxppc-dev/2021/06/1398799.md

```text
On Mon, May 31, 2021 at 04:12:15PM +0800, Wesley Sheng wrote:
> Replace "It" with "If", since it is a conditional statement.
> 
> Signed-off-by: Wesley Sheng <redacted>

Applied to pci/error for v5.14 with Krzysztof's reviewed-by and
subject "Documentation: PCI: Fix typo in pci-error-recovery.rst" to
match previous convention, thanks!

> ---
>  Documentation/PCI/pci-error-recovery.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/PCI/pci-error-recovery.rst b/Documentation/PCI/pci-error-recovery.rst
> index 84ceebb08cac..187f43a03200 100644
> --- a/Documentation/PCI/pci-error-recovery.rst
> +++ b/Documentation/PCI/pci-error-recovery.rst
> @@ -295,7 +295,7 @@ and let the driver restart normal I/O processing.
>  A driver can still return a critical failure for this function if
>  it can't get the device operational after reset.  If the platform
>  previously tried a soft reset, it might now try a hard reset (power
> -cycle) and then call slot_reset() again.  It the device still can't
> +cycle) and then call slot_reset() again.  If the device still can't
>  be recovered, there is nothing more that can be done;  the platform
>  will typically report a "permanent failure" in such a case.  The
>  device will be considered "dead" in this case.
> -- 
> 2.25.1
> 
```
