[PATCH 11/15] powerpc: convert to setup_initial_init_mm()

Use setup_initial_init_mm() helper to simplify code.

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Kefeng Wang <redacted>
---
 arch/powerpc/kernel/setup-common.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 046fe21b5c3b..c046d99efd18 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c

@@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)
 
 	klp_init_thread_info(&init_task);
 
-	init_mm.start_code = (unsigned long)_stext;
-	init_mm.end_code = (unsigned long) _etext;
-	init_mm.end_data = (unsigned long) _edata;
-	init_mm.brk = klimit;
+	setup_initial_init_mm(_stext, _etext, _edata, _end);
 
 	mm_iommu_init(&init_mm);
 	irqstack_early_init();

-- 
2.26.2

Kefeng Wang [off-list ref] writes:

This function definition is not visible for those who have subscribed only to
linuxppc-dev mailing list. I had to do a web-search with the ID. 

Thanks,
Santosh

 
 	mm_iommu_init(&init_mm);
 	irqstack_early_init();
-- 
2.26.2

Santosh Sivaraj [off-list ref] a écrit :

Kefeng Wang [off-list ref] writes:

quoted

Use setup_initial_init_mm() helper to simplify code.

I only got that patch, and patchwork as well (https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=246315)

Can you tell where I can see and get the full series ?

And next time can you copy all patches to linuxppc-dev

Thanks
Christophe

quoted

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Kefeng Wang <redacted>
---
 arch/powerpc/kernel/setup-common.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 046fe21b5c3b..c046d99efd18 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c

@@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)

 	klp_init_thread_info(&init_task);

-	init_mm.start_code = (unsigned long)_stext;
-	init_mm.end_code = (unsigned long) _etext;
-	init_mm.end_data = (unsigned long) _edata;
-	init_mm.brk = klimit;
+	setup_initial_init_mm(_stext, _etext, _edata, _end);

This function definition is not visible for those who have subscribed only to
linuxppc-dev mailing list. I had to do a web-search with the ID.

Thanks,
Santosh

quoted

 	mm_iommu_init(&init_mm);
 	irqstack_early_init();
--
2.26.2

Kefeng Wang [off-list ref] a écrit :

This looks wrong, should be klimit instead of _end IIUC

 	mm_iommu_init(&init_mm);
 	irqstack_early_init();
--
2.26.2

On 2021/5/29 23:22, Christophe Leroy wrote:

Santosh Sivaraj [off-list ref] a écrit :

quoted

Kefeng Wang [off-list ref] writes:

quoted

Use setup_initial_init_mm() helper to simplify code.

I only got that patch, and patchwork as well (https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=246315)

Can you tell where I can see and get the full series ?

And next time can you copy all patches to linuxppc-dev

ok, will be careful next time, thank for your reminding.

Thanks
Christophe

quoted

quoted

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Kefeng Wang <redacted>
---
 arch/powerpc/kernel/setup-common.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 046fe21b5c3b..c046d99efd18 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c

@@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)

     klp_init_thread_info(&init_task);

-    init_mm.start_code = (unsigned long)_stext;
-    init_mm.end_code = (unsigned long) _etext;
-    init_mm.end_data = (unsigned long) _edata;
-    init_mm.brk = klimit;
+    setup_initial_init_mm(_stext, _etext, _edata, _end);

This function definition is not visible for those who have subscribed only to
linuxppc-dev mailing list. I had to do a web-search with the ID.

Thanks,
Santosh

quoted

     mm_iommu_init(&init_mm);
     irqstack_early_init();
-- 
2.26.2

.

On 2021/5/30 0:16, Christophe Leroy wrote:

Kefeng Wang [off-list ref] a écrit :

quoted

Use setup_initial_init_mm() helper to simplify code.

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Kefeng Wang <redacted>
---
 arch/powerpc/kernel/setup-common.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 046fe21b5c3b..c046d99efd18 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c

@@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)

     klp_init_thread_info(&init_task);

-    init_mm.start_code = (unsigned long)_stext;
-    init_mm.end_code = (unsigned long) _etext;
-    init_mm.end_data = (unsigned long) _edata;
-    init_mm.brk = klimit;
+    setup_initial_init_mm(_stext, _etext, _edata, _end);

This looks wrong, should be klimit instead of _end IIUC

see  arch/powerpc/kernel/setup-common.c:

unsigned long klimit = (unsigned long) _end;

the setup_initial_init_mm helper [1] should use the original _end


+static inline void setup_initial_init_mm(char *start_code,
+					 char *end_code,
+					 char *end_data,
+					 char *brk)
+{
+	init_mm.start_code = (unsigned long)start_code;
+	init_mm.end_code = (unsigned long)end_code;
+	init_mm.end_data = (unsigned long)end_data;
+	init_mm.brk = (unsigned long)brk;
+}

[1] https://lkml.org/lkml/2021/5/29/84

quoted

     mm_iommu_init(&init_mm);
     irqstack_early_init();
-- 
2.26.2

.