# RE: \[PATCH v1 12/12\] powerpc: Replace PPC\_INST\_NOP by PPC\_RAW\_NOP()

- From: David Laight \<hidden\>
- Date: 2021-05-20 11:13:50 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/05/1385486
- Thread: https://ratatoskr.run/linuxppc-dev/2021/05/1385150/t.md

```text
From: Christophe Leroy
> Sent: 20 May 2021 11:23
> 
> On the road to removing all PPC_INST_xx defines in
> asm/ppc-opcodes.h, change PPC_INST_NOP to PPC_RAW_NOP().
...
> @@ -475,7 +474,7 @@
>  #define PPC_RAW_ADD_DOT(t, a, b)	(PPC_INST_ADD | ___PPC_RT(t) | ___PPC_RA(a) | ___PPC_RB(b) | 0x1)
>  #define PPC_RAW_ADDC(t, a, b)		(0x7c000014 | ___PPC_RT(t) | ___PPC_RA(a) | ___PPC_RB(b))
>  #define PPC_RAW_ADDC_DOT(t, a, b)	(0x7c000014 | ___PPC_RT(t) | ___PPC_RA(a) | ___PPC_RB(b) | 0x1)
> -#define PPC_RAW_NOP()			(PPC_INST_NOP)
> +#define PPC_RAW_NOP()			PPC_RAW_ORI(0, 0, 0)

Shouldn't that be PPC_RAW_ORI(_R0, _R0, 0) ?

Also PPC_RAW_ADC_DOT() could be (PPC_RAW_ADC(t, a, b) | 0x1)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

```