# Re: \[PATCH v2 1/2\] kprobes: Allow architectures to override optinsn page allocation

- From: Naveen N. Rao \<hidden\>
- Date: 2021-05-20 09:18:52 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/05/1384437
- Thread: https://ratatoskr.run/linuxppc-dev/2021/05/1376508/t.md

```text
Christophe Leroy wrote:
> Some architectures like powerpc require a non standard
> allocation of optinsn page, because module pages are
> too far from the kernel for direct branches.
>
> Define weak alloc_optinsn_page() and free_optinsn_page(), that
> fall back on alloc_insn_page() and free_insn_page() when not
> overriden by the architecture.
 ^^^^^^^^^
 overridden - courtesy of checkpatch.

>
> Suggested-by: Masami Hiramatsu <mhiramat@kernel.org>
> Signed-off-by: Christophe Leroy <redacted>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> v2: Added missing prototypes in linux/kprobes.h
> ---
>  include/linux/kprobes.h |  3 +++
>  kernel/kprobes.c        | 14 ++++++++++++--
>  2 files changed, 15 insertions(+), 2 deletions(-)

LGTM. For the series:
Reviewed-by: Naveen N. Rao <redacted>


- Naveen
```