# \[PATCH net-next\] ibmveth: fix kobj\_to\_dev.cocci warnings

- Subsystems: LINUX FOR POWERPC (32-BIT AND 64-BIT), IBM Power Virtual Ethernet Device Driver, NETWORKING DRIVERS, THE REST
- Maintainers: Madhavan Srinivasan, Nick Child, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
- List: linuxppc-dev
- 3 messages, 3 authors
- Page: https://ratatoskr.run/linuxppc-dev/2021/05/1382766/t

## \[PATCH net-next\] ibmveth: fix kobj\_to\_dev.cocci warnings

- From: YueHaibing \<hidden\>
- Date: 2021-05-19 02:29:08 
- Message: https://ratatoskr.run/linuxppc-dev/2021/05/1382766.md

```text
Use kobj_to_dev() instead of container_of()

Generated by: scripts/coccinelle/api/kobj_to_dev.cocci

Signed-off-by: YueHaibing <redacted>
---
 drivers/net/ethernet/ibm/ibmveth.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 7fea9ae60f13..bc67a7ee872b 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1799,8 +1799,7 @@ static ssize_t veth_pool_store(struct kobject *kobj, struct attribute *attr,
 	struct ibmveth_buff_pool *pool = container_of(kobj,
 						      struct ibmveth_buff_pool,
 						      kobj);
-	struct net_device *netdev = dev_get_drvdata(
-	    container_of(kobj->parent, struct device, kobj));
+	struct net_device *netdev = dev_get_drvdata(kobj_to_dev(kobj->parent));
 	struct ibmveth_adapter *adapter = netdev_priv(netdev);
 	long value = simple_strtol(buf, NULL, 10);
 	long rc;
-- 
2.17.1

```

## Re: \[PATCH net-next\] ibmveth: fix kobj\_to\_dev.cocci warnings

- From: Lijun Pan \<hidden\>
- Date: 2021-05-19 05:21:58 
- Message: https://ratatoskr.run/linuxppc-dev/2021/05/1382871.md

```text


> On May 18, 2021, at 9:28 PM, YueHaibing [ref] wrote:
> 
> Use kobj_to_dev() instead of container_of()
> 
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
> 
> Signed-off-by: YueHaibing <redacted>
> ---

Acked-by: Lijun Pan <redacted>


> drivers/net/ethernet/ibm/ibmveth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
> index 7fea9ae60f13..bc67a7ee872b 100644
> --- a/drivers/net/ethernet/ibm/ibmveth.c
> +++ b/drivers/net/ethernet/ibm/ibmveth.c
> @@ -1799,8 +1799,7 @@ static ssize_t veth_pool_store(struct kobject *kobj, struct attribute *attr,
> 	struct ibmveth_buff_pool *pool = container_of(kobj,
> 						      struct ibmveth_buff_pool,
> 						      kobj);
> -	struct net_device *netdev = dev_get_drvdata(
> -	    container_of(kobj->parent, struct device, kobj));
> +	struct net_device *netdev = dev_get_drvdata(kobj_to_dev(kobj->parent));
> 	struct ibmveth_adapter *adapter = netdev_priv(netdev);
> 	long value = simple_strtol(buf, NULL, 10);
> 	long rc;
> -- 
> 2.17.1
> 

```

## Re: \[PATCH net-next\] ibmveth: fix kobj\_to\_dev.cocci warnings

- From: patchwork-bot+netdevbpf@kernel.org
- Date: 2021-05-19 19:10:16 
- Message: https://ratatoskr.run/linuxppc-dev/2021/05/1383846.md

```text
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 19 May 2021 10:28:49 +0800 you wrote:
> Use kobj_to_dev() instead of container_of()
> 
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
> 
> Signed-off-by: YueHaibing <redacted>
> ---
>  drivers/net/ethernet/ibm/ibmveth.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Here is the summary with links:
  - [net-next] ibmveth: fix kobj_to_dev.cocci warnings
    https://git.kernel.org/netdev/net-next/c/1756055de284

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


```